[PATCH mptcp-net] selftests: mptcp: simult flows: re-adapt BW

[PATCH mptcp-net] selftests: mptcp: simult flows: re-adapt BW

[Matthieu Baerts (NGI0)]

Recently, the bandwidth in simult flows selftest has been reduced. The
idea was to improve the situation in slow environments. It helped in
some, but not in all of them. With a longer transfer, it is also
possible to get more instabilities along the way.

We can increase a bit the rate limit for the unbalanced bandwidth cases,
but limit the total of the two links to 20 Mbps, like the balanced
bandwidth cases. The same 3:1 ratio is still being used like before, not
to change the nature of the test.

Fixes: 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/simult_flows.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
index 0cc964e6f2c1..619be0e1acf5 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -287,9 +287,9 @@ run_test 10 10 0 0 "balanced bwidth"
 run_test 10 10 1 25 "balanced bwidth with unbalanced delay"
 
 # we still need some additional infrastructure to pass the following test-cases
-run_test 10 3 0 0 "unbalanced bwidth"
-run_test 10 3 1 25 "unbalanced bwidth with unbalanced delay"
-run_test 10 3 25 1 "unbalanced bwidth with opposed, unbalanced delay"
+run_test 15 5 0 0 "unbalanced bwidth"
+run_test 15 5 1 25 "unbalanced bwidth with unbalanced delay"
+run_test 15 5 25 1 "unbalanced bwidth with opposed, unbalanced delay"
 
 mptcp_lib_result_print_all_tap
 exit $ret

---
base-commit: c2469b38e369c3f2b9577beeb9470cc757abc1b9
change-id: 20240208-selftests-mptcp-simult_flows_faster-0a3b46f5cde6

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: selftests: mptcp: simult flows: re-adapt BW: Tests Results

[MPTCP CI]

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI (GitHub Action) did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/7827490298

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/d795f50e2612


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: selftests: mptcp: simult flows: re-adapt BW: Tests Results

[MPTCP CI]

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI (Cirrus) did some validations with a debug kernel and here is its report:

- KVM Validation: debug (except selftest_mptcp_join):
  - Unstable: 1 failed test(s): selftest_diag 🔴:
  - Task: https://cirrus-ci.com/task/5554170015514624
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5554170015514624/summary/summary.txt

- KVM Validation: debug (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/6680069922357248
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6680069922357248/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/d795f50e2612


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: [PATCH mptcp-net] selftests: mptcp: simult flows: re-adapt BW

[Mat Martineau]

On Thu, 8 Feb 2024, Matthieu Baerts (NGI0) wrote:

> Recently, the bandwidth in simult flows selftest has been reduced. The
> idea was to improve the situation in slow environments. It helped in
> some, but not in all of them. With a longer transfer, it is also
> possible to get more instabilities along the way.
>
> We can increase a bit the rate limit for the unbalanced bandwidth cases,
> but limit the total of the two links to 20 Mbps, like the balanced
> bandwidth cases. The same 3:1 ratio is still being used like before, not
> to change the nature of the test.
>
> Fixes: 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Looks reasonable, thanks Matthieu.

Reviewed-by: Mat Martineau <martineau@kernel.org>

> ---
> tools/testing/selftests/net/mptcp/simult_flows.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
> index 0cc964e6f2c1..619be0e1acf5 100755
> --- a/tools/testing/selftests/net/mptcp/simult_flows.sh
> +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
> @@ -287,9 +287,9 @@ run_test 10 10 0 0 "balanced bwidth"
> run_test 10 10 1 25 "balanced bwidth with unbalanced delay"
>
> # we still need some additional infrastructure to pass the following test-cases
> -run_test 10 3 0 0 "unbalanced bwidth"
> -run_test 10 3 1 25 "unbalanced bwidth with unbalanced delay"
> -run_test 10 3 25 1 "unbalanced bwidth with opposed, unbalanced delay"
> +run_test 15 5 0 0 "unbalanced bwidth"
> +run_test 15 5 1 25 "unbalanced bwidth with unbalanced delay"
> +run_test 15 5 25 1 "unbalanced bwidth with opposed, unbalanced delay"
>
> mptcp_lib_result_print_all_tap
> exit $ret
>
> ---
> base-commit: c2469b38e369c3f2b9577beeb9470cc757abc1b9
> change-id: 20240208-selftests-mptcp-simult_flows_faster-0a3b46f5cde6
>
> Best regards,
> -- 
> Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
>
>

Re: selftests: mptcp: simult flows: re-adapt BW: Tests Results

[MPTCP CI]

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI (GitHub Action) did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/7837948894

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/cf099624ce51


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: selftests: mptcp: simult flows: re-adapt BW: Tests Results

[MPTCP CI]

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI (Cirrus) did some validations with a debug kernel and here is its report:

- KVM Validation: debug (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/4644410579746816
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4644410579746816/summary/summary.txt

- KVM Validation: debug (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5058570014687232
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5058570014687232/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/cf099624ce51


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: [PATCH mptcp-net] selftests: mptcp: simult flows: re-adapt BW

[Matthieu Baerts]

Hi Mat,

On 09/02/2024 01:30, Mat Martineau wrote:
> On Thu, 8 Feb 2024, Matthieu Baerts (NGI0) wrote:
> 
>> Recently, the bandwidth in simult flows selftest has been reduced. The
>> idea was to improve the situation in slow environments. It helped in
>> some, but not in all of them. With a longer transfer, it is also
>> possible to get more instabilities along the way.
>>
>> We can increase a bit the rate limit for the unbalanced bandwidth cases,
>> but limit the total of the two links to 20 Mbps, like the balanced
>> bandwidth cases. The same 3:1 ratio is still being used like before, not
>> to change the nature of the test.
>>
>> Fixes: 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> Looks reasonable, thanks Matthieu.
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you for the review!

Now in our tree (fix for -net):

New patches for t/upstream-net and t/upstream:
- 7e6c60f9e796: selftests: mptcp: simult flows: re-adapt BW
- Results: 6075087dd1c3..bef0b46af378 (export-net)
- Results: 081844c2b78a..78a4d8e40bf5 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20240209T140100
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20240209T140100

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.