[PATCH mptcp-net] selftests: mptcp: fix MP_FAIL test-case

[PATCH mptcp-net] selftests: mptcp: fix MP_FAIL test-case

[Paolo Abeni]

The mentioned tests sometimes fails because the data
transfer completes before any packet is sent on the 2nd
link (the failing one).

Address the issue reducing the "virtual" b/w available
on the primary link.

Fixes: bfd4cdbe7032 ("selftests: mptcp: add MP_FAIL reset testcase")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
together with the previous patch this fixes issues/265 for
good here. I'm not adding the Close tag due to the mentioned
dep, which may take a different/longer route
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index a98fee834950..0d65295c1b33 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -2734,7 +2734,7 @@ fail_tests()
 
 	# multiple subflows
 	if reset_with_fail "MP_FAIL MP_RST" 2; then
-		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 20mbit delay 1
+		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 10mbit delay 5
 		pm_nl_set_limits $ns1 0 1
 		pm_nl_set_limits $ns2 0 1
 		pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
-- 
2.35.1

Re: [PATCH mptcp-net] selftests: mptcp: fix MP_FAIL test-case

[Mat Martineau]

On Fri, 29 Apr 2022, Paolo Abeni wrote:

> The mentioned tests sometimes fails because the data
> transfer completes before any packet is sent on the 2nd
> link (the failing one).
>
> Address the issue reducing the "virtual" b/w available
> on the primary link.
>
> Fixes: bfd4cdbe7032 ("selftests: mptcp: add MP_FAIL reset testcase")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> together with the previous patch this fixes issues/265 for
> good here. I'm not adding the Close tag due to the mentioned
> dep, which may take a different/longer route
> ---
> tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index a98fee834950..0d65295c1b33 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -2734,7 +2734,7 @@ fail_tests()
>
> 	# multiple subflows
> 	if reset_with_fail "MP_FAIL MP_RST" 2; then
> -		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 20mbit delay 1
> +		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 10mbit delay 5
> 		pm_nl_set_limits $ns1 0 1
> 		pm_nl_set_limits $ns2 0 1
> 		pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
> -- 
> 2.35.1
>
>
>

I'm assuming this patch is supposed to be tagged for mptcp-next, since 
fail_tests() is not in the net branch?


--
Mat Martineau
Intel

Re: selftests: mptcp: fix MP_FAIL test-case: Tests Results

[MPTCP CI]

Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5704510495522816
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5704510495522816/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 1 failed test(s): selftest_diag - Critical: 1 Call Trace(s) ❌:
  - Task: https://cirrus-ci.com/task/5141560542101504
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5141560542101504/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/d97a7b7382ca


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)

Re: [PATCH mptcp-net] selftests: mptcp: fix MP_FAIL test-case

[Mat Martineau]

On Fri, 29 Apr 2022, Paolo Abeni wrote:

> The mentioned tests sometimes fails because the data
> transfer completes before any packet is sent on the 2nd
> link (the failing one).
>
> Address the issue reducing the "virtual" b/w available
> on the primary link.
>
> Fixes: bfd4cdbe7032 ("selftests: mptcp: add MP_FAIL reset testcase")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> together with the previous patch this fixes issues/265 for
> good here. I'm not adding the Close tag due to the mentioned
> dep, which may take a different/longer route
> ---
> tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index a98fee834950..0d65295c1b33 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -2734,7 +2734,7 @@ fail_tests()
>
> 	# multiple subflows
> 	if reset_with_fail "MP_FAIL MP_RST" 2; then
> -		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 20mbit delay 1
> +		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 10mbit delay 5

The "MP_FAIL MP_RST" test still fails within a couple of minutes on my 
desktop with this change. I changed 10mbit to 1mbit and so far it is still 
running. You ok with slowing it down even more?

> 		pm_nl_set_limits $ns1 0 1
> 		pm_nl_set_limits $ns2 0 1
> 		pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
> -- 
> 2.35.1
>
>
>

--
Mat Martineau
Intel

Re: [PATCH mptcp-net] selftests: mptcp: fix MP_FAIL test-case

[Paolo Abeni]

Hello,

On Fri, 2022-04-29 at 12:46 -0700, Mat Martineau wrote:
> On Fri, 29 Apr 2022, Paolo Abeni wrote:
> 
> > The mentioned tests sometimes fails because the data
> > transfer completes before any packet is sent on the 2nd
> > link (the failing one).
> > 
> > Address the issue reducing the "virtual" b/w available
> > on the primary link.
> > 
> > Fixes: bfd4cdbe7032 ("selftests: mptcp: add MP_FAIL reset testcase")
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> > ---
> > together with the previous patch this fixes issues/265 for
> > good here. I'm not adding the Close tag due to the mentioned
> > dep, which may take a different/longer route
> > ---
> > tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> > index a98fee834950..0d65295c1b33 100755
> > --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> > +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> > @@ -2734,7 +2734,7 @@ fail_tests()
> > 
> > 	# multiple subflows
> > 	if reset_with_fail "MP_FAIL MP_RST" 2; then
> > -		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 20mbit delay 1
> > +		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 10mbit delay 5
> 
> The "MP_FAIL MP_RST" test still fails within a couple of minutes on my 
> desktop with this change. I changed 10mbit to 1mbit and so far it is still 
> running. You ok with slowing it down even more?

[sorry I almost missed this comment]. Just to be sure, is such test
running on top of the pedit patch? (we need both of them). Otherwise no
objection to reduce the rate even more.

Thanks!

Paolo

Re: [PATCH mptcp-net] selftests: mptcp: fix MP_FAIL test-case

[Mat Martineau]

On Tue, 3 May 2022, Paolo Abeni wrote:

> Hello,
>
> On Fri, 2022-04-29 at 12:46 -0700, Mat Martineau wrote:
>> On Fri, 29 Apr 2022, Paolo Abeni wrote:
>>
>>> The mentioned tests sometimes fails because the data
>>> transfer completes before any packet is sent on the 2nd
>>> link (the failing one).
>>>
>>> Address the issue reducing the "virtual" b/w available
>>> on the primary link.
>>>
>>> Fixes: bfd4cdbe7032 ("selftests: mptcp: add MP_FAIL reset testcase")
>>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>>> ---
>>> together with the previous patch this fixes issues/265 for
>>> good here. I'm not adding the Close tag due to the mentioned
>>> dep, which may take a different/longer route
>>> ---
>>> tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
>>> index a98fee834950..0d65295c1b33 100755
>>> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
>>> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
>>> @@ -2734,7 +2734,7 @@ fail_tests()
>>>
>>> 	# multiple subflows
>>> 	if reset_with_fail "MP_FAIL MP_RST" 2; then
>>> -		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 20mbit delay 1
>>> +		tc -n $ns2 qdisc add dev ns2eth1 root netem rate 10mbit delay 5
>>
>> The "MP_FAIL MP_RST" test still fails within a couple of minutes on my
>> desktop with this change. I changed 10mbit to 1mbit and so far it is still
>> running. You ok with slowing it down even more?
>
> [sorry I almost missed this comment]. Just to be sure, is such test
> running on top of the pedit patch? (we need both of them). Otherwise no
> objection to reduce the rate even more.
>

Yes, I was testing with both patches applied.

--
Mat Martineau
Intel