From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168
Date: Sun, 31 Mar 2019 20:16:51 +0200 [thread overview]
Message-ID: <04d8d554-6f29-365a-c0d9-325744bf43f5@gmail.com> (raw)
In-Reply-To: <20190331.111320.1948640028158399763.davem@davemloft.net>
On 31.03.2019 20:13, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Sun, 31 Mar 2019 15:43:59 +0200
>
>> @@ -5456,12 +5448,6 @@ static void rtl_hw_start_8168(struct rtl8169_private *tp)
>> {
>> RTL_W8(tp, MaxTxPacketSize, TxPacketMax);
>>
>> - tp->cp_cmd &= ~INTT_MASK;
>> - tp->cp_cmd |= PktCntrDisable | INTT_1;
>> - RTL_W16(tp, CPlusCmd, tp->cp_cmd);
>> -
>> - RTL_W16(tp, IntrMitigate, 0x5100);
>> -
>> /* Work around for RxFIFO overflow. */
>
> This patch isn't against net-next.
>
> I'm guessing it's against a tree with the RX coalesce disable changes
> applied.
>
You're right, sorry. It will apply cleanly only once net has been merged
into net-next. However, if I rebase this patch to net-next, then merging
net to net-next will complain. Can we defer applying this patch until net
has been merged?
next prev parent reply other threads:[~2019-03-31 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 13:43 [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168 Heiner Kallweit
2019-03-31 18:13 ` David Miller
2019-03-31 18:16 ` Heiner Kallweit [this message]
2019-03-31 18:23 ` David Miller
2019-03-31 18:33 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04d8d554-6f29-365a-c0d9-325744bf43f5@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox