Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168
Date: Sun, 31 Mar 2019 11:13:20 -0700 (PDT)	[thread overview]
Message-ID: <20190331.111320.1948640028158399763.davem@davemloft.net> (raw)
In-Reply-To: <23289428-64e1-206c-385e-b1ce9c4cc14c@gmail.com>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 31 Mar 2019 15:43:59 +0200

> @@ -5456,12 +5448,6 @@ static void rtl_hw_start_8168(struct rtl8169_private *tp)
>  {
>  	RTL_W8(tp, MaxTxPacketSize, TxPacketMax);
>  
> -	tp->cp_cmd &= ~INTT_MASK;
> -	tp->cp_cmd |= PktCntrDisable | INTT_1;
> -	RTL_W16(tp, CPlusCmd, tp->cp_cmd);
> -
> -	RTL_W16(tp, IntrMitigate, 0x5100);
> -
>  	/* Work around for RxFIFO overflow. */

This patch isn't against net-next.

I'm guessing it's against a tree with the RX coalesce disable changes
applied.

  reply	other threads:[~2019-03-31 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-31 13:43 [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168 Heiner Kallweit
2019-03-31 18:13 ` David Miller [this message]
2019-03-31 18:16   ` Heiner Kallweit
2019-03-31 18:23     ` David Miller
2019-03-31 18:33       ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190331.111320.1948640028158399763.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox