Re: [PATCH net-next 3/4] netlink: specs: dpll: pin-get has no dump filter

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 04/09/2026 20:10, Jakub Kicinski wrote:
> The op doc promises "dump request with target dpll - list all the pins
> registered with a given dpll device" and "do request with target dpll
> and target pin". Neither exists. pin-get uses attribute-set: pin, so
> the id in both requests is DPLL_A_PIN_ID, not a device id; there is no
> reachable "target dpll" attribute at all (DPLL_A_PIN_PARENT_ID is in
> neither list). dpll_nl_pin_get_dumpit() does not look at the request,
> it walks dpll_pin_xa from ctx->idx and emits every registered,
> available pin, and there is no dump start callback to consume an id
> either.
> 
> So the generated dpll_pin_get_dump() sends an id, gets the full list
> back and reports no error. Drop the id from the dump request and the
> two targeting claims from the doc.
> 
> Present since commit 3badff3a25d8 ("dpll: spec: Add Netlink spec in
> YAML").
> Same caveat as for pin-set: sending DPLL_A_PIN_ID in a pin-get dump now
> fails validation instead of being ignored.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>