Re: [PATCH net-next 2/4] netlink: specs: dpll: drop the pin-set attributes nothing implements

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 04/09/2026 20:10, Jakub Kicinski wrote:
> pin-set advertises top level direction, prio and state, so the
> generated policy accepts them and the generated user space API grows
> setters for them. dpll_pin_set_from_nlattr() has cases only for
> FREQUENCY, PHASE_ADJUST, PARENT_DEVICE, PARENT_PIN, ESYNC_FREQUENCY and
> REFERENCE_SYNC - the request succeeds, does nothing and produces no
> extack. The three values are only actionable inside the parent-device
> nest, where dpll_pin_parent_device_set() handles them next to
> DPLL_A_PIN_PARENT_ID, which is what makes them meaningful: a pin can be
> registered with more than one device.
> 
> Never implemented - "git log -S 'case DPLL_A_PIN_PRIO'" on
> dpll_netlink.c comes up empty - the spec has advertised them since
> commit 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML").
> 
> Note that this does change what the kernel accepts: sending one of the
> three now fails validation instead of being ignored.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

@Arkadiusz was this a plan that never happened?

Anyways, LGMT
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>