Re: [RFC] hwmon: (tps23861) PSE-PD support, extend hwmon driver or move to pse-pd?

[Kory Maincent <kory.maincent@bootlin.com>]

On 11/2/26 15:54, Guenter Roeck wrote:
> On 11/2/26 01:49, Kory Maincent wrote:
>>
>> On 11/1/26 20:57, Andrew Lunn wrote:
>>> On Sun, Nov 01, 2026 at 11:09:42AM -0800, Guenter Roeck wrote:
>>>> On 11/1/26 10:50, Roman Kuzmitskii wrote:
>>>>> On 11/2/26 1:38 AM, Guenter Roeck wrote:
>>>>>> On 11/1/26 10:02, Roman Kuzmitskii wrote:
>>>>>>> openwrt reviewers asked me to check with you first which way you 
>>>>>>> prefer:
>>>>>>> 1. extend hwmon driver with PSE-PD (like it is done right now)
>>>>>>> 2. move driver to drivers/net/pse-pd and extend it with PSE-PD
>>>>>>> 3. something else
>>
>> I am currently working on this topic by extending the tps23881 driver.
>> Please don't do it yourself to avoid working in parallel on the same 
>> topic. On the other hand, it would be nice if you can test it.
>> Roman I will add you in CC of my series.
>>
>>>>>>>
>>>>>> The hardware monitoring "enable" attribute is supposed to enable 
>>>>>> monitoring,
>>>>>> not to enable some power delivery or network (or any other) port. 
>>>>>> That "port
>>>>>> enable" feature using the hwmon ABI was sneaked in, and I am 
>>>>>> inclined to just
>>>>>> remove the upstream driver for severe ABI violation.
>>
>> Do you think it would be possible to remove the current tps23861 
>> driver and binding? This would break the backward compatibility.
>> I am currently using "tps23861-poe" compatible name binding.
>>
> ... and you probably also use the hwmon "enable" attribute
> to enable and disable ports on this chip. Again, that is an ABI abuse.
> I'll refrain from removing the driver for now, but I will likely
> remove the attribute if//when I find the time to do it.

I thinks you misread or I was no clear enough. I am working on expanding 
the tps23881 PSE driver to support the tps23861 version.
I am not using at all the hwmon framework in that development.
But as the binding tps23861 is already reserved for hwmon I use a new 
"tps23861-poe" compatible name binding.
To me, I agree to remove the hwmon driver but this will break backward 
compatibility. I am not a hwmon maintainer so it's not my decision to take.

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com