Re: [RFC] hwmon: (tps23861) PSE-PD support, extend hwmon driver or move to pse-pd?

[Guenter Roeck <linux@roeck-us.net>]

On 11/1/26 10:50, Roman Kuzmitskii wrote:
> On 11/2/26 1:38 AM, Guenter Roeck wrote:
>> On 11/1/26 10:02, Roman Kuzmitskii wrote:
>>> openwrt reviewers asked me to check with you first which way you prefer:
>>> 1. extend hwmon driver with PSE-PD (like it is done right now)
>>> 2. move driver to drivers/net/pse-pd and extend it with PSE-PD
>>> 3. something else
>>>
>> The hardware monitoring "enable" attribute is supposed to enable monitoring,
>> not to enable some power delivery or network (or any other) port. That "port
>> enable" feature using the hwmon ABI was sneaked in, and I am inclined to just
>> remove the upstream driver for severe ABI violation.
>>
>> Guenter
> 
> thanks, does second option look okay with taking tps23861 to drivers/net/pse-pd
> with enable attribute going away?
> 
A perfect solution would be to move the driver to drivers/net/pse-pd (or elsewhere)
and implement the hwmon part as auxiliary driver, but I am also ok with moving it all.
Note that I do not review hwmon drivers outside drivers/hwmon, so if you move the
driver to drivers/net/pse-pd you can abuse the hwmon ABI as much as you want.

Guenter