Netdev List
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Roman Kuzmitskii <roman@damex.org>,
	linux-hwmon@vger.kernel.org, netdev@vger.kernel.org,
	robert.marko@sartura.hr, luka.perkov@sartura.hr,
	o.rempel@pengutronix.de
Subject: Re: [RFC] hwmon: (tps23861) PSE-PD support, extend hwmon driver or move to pse-pd?
Date: Mon, 2 Nov 2026 18:56:02 +0100	[thread overview]
Message-ID: <5db15d98-ee57-4c78-8514-dfc5da52d6b4@bootlin.com> (raw)
In-Reply-To: <300336f7-94d2-4075-abf3-2c1ddc48fa69@lunn.ch>



On 11/2/26 18:33, Andrew Lunn wrote:
> On Mon, Nov 02, 2026 at 05:57:06PM +0100, Kory Maincent wrote:
>>
>>
>> On 11/2/26 17:36, Andrew Lunn wrote:
>>>> I am not using at all the hwmon framework in that development.
>>>> But as the binding tps23861 is already reserved for hwmon I use a new
>>>> "tps23861-poe" compatible name binding.
>>>> To me, I agree to remove the hwmon driver but this will break backward
>>>> compatibility. I am not a hwmon maintainer so it's not my decision to take.
>>>
>>> Is the hwmon code applicable to the tps238XX range of devices?
>>>
>>> Can that hwmon code by merged into the PoE driver? Without API
>>> changes, apart from dropping the API abuse case? The compatible can
>>> then be transplanted into the PoE driver?
>>
>> Should we really want to add the hwmon framework in the driver only to keep
>> the binding name?
> 
> That is why i asked if the code is applicable. If it is using hwmon to
> show the temperature of the PoE controller, it probably is
> applicable.
> 
> If it is just repeating the same information which is available in
> ethtool, then it is not so useful. If it is not useful, the hwmon
> driver should be marked as deprecated, and a pointer added to the real
> PoE driver.

Oh ok. The information reported by the hwmon driver that are not in the 
PSE driver are:
- current and voltage while PSE is reporting the power
- the temperature
- the port resistance

Not sure if they are useful. For the temperature the PSE raise a 
notification in case of over temperature.
Anyway if we want to report these information I think we will report 
them through ethtool not in sysfs. We can later add a new ops to report 
the temperature if people want it.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


  reply	other threads:[~2026-11-02 17:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01 18:02 [RFC] hwmon: (tps23861) PSE-PD support, extend hwmon driver or move to pse-pd? Roman Kuzmitskii
2026-11-01 18:38 ` Guenter Roeck
2026-11-01 18:50   ` Roman Kuzmitskii
2026-11-01 19:09     ` Guenter Roeck
2026-11-01 19:57       ` Andrew Lunn
2026-11-02  9:49         ` Kory Maincent
2026-11-02 14:54           ` Guenter Roeck
2026-11-02 15:05             ` Kory Maincent
2026-11-02 16:36               ` Andrew Lunn
2026-11-02 16:57                 ` Kory Maincent
2026-11-02 17:33                   ` Andrew Lunn
2026-11-02 17:56                     ` Kory Maincent [this message]
2026-11-01 20:57   ` Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5db15d98-ee57-4c78-8514-dfc5da52d6b4@bootlin.com \
    --to=kory.maincent@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=luka.perkov@sartura.hr \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robert.marko@sartura.hr \
    --cc=roman@damex.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox