[net-next 00/36] bnx2x patch series

[net-next 00/36] bnx2x patch series

[Eilon Greenstein]

Hi Dave,

Here is a patch series for the bnx2x. This patch series also replace the
FW, so
it contains two big blobs - the new fw and the removal of the old one.
Those
patches do not contain anything but the ihex - the actually change to
the driver
is in patch number 2 which is small enough to fit the mailing list.

For those who wish to see all the patches, including the ihex, I also
updated
http://linux.broadcom.com/eilong/ to contain this patch series.

Please consider applying to net-next.

Thanks,
Eilon

 drivers/net/Kconfig                 |    1 +
 drivers/net/bnx2x.h                 |  125 +-
 drivers/net/bnx2x_dump.h            |  890 ++--
 drivers/net/bnx2x_fw_defs.h         |  379 +-
 drivers/net/bnx2x_hsi.h             |  395 +-
 drivers/net/bnx2x_init.h            |  320 +-
 drivers/net/bnx2x_init_ops.h        |  419 +-
 drivers/net/bnx2x_link.c            | 1528 +++--
 drivers/net/bnx2x_link.h            |   49 +-
 drivers/net/bnx2x_main.c            | 2058 ++++---
 drivers/net/bnx2x_reg.h             | 1032 +---
 firmware/Makefile                   |    2 +-
 firmware/bnx2x-e1-4.8.53.0.fw.ihex  |10364 ----------------------------
 firmware/bnx2x-e1-5.0.21.0.fw.ihex  |10184 +++++++++++++++++++++++++++
 firmware/bnx2x-e1h-4.8.53.0.fw.ihex |12028
--------------------------------
 firmware/bnx2x-e1h-5.0.21.0.fw.ihex |12855
+++++++++++++++++++++++++++++++++++
 16 files changed, 26764 insertions(+), 25865 deletions(-)

Re: [net-next 00/36] bnx2x patch series

[David Miller]

Come on... 36 patches? :-/

Please trickle changes in, don't send patch bombs.  I think
I've told you this not once, but several times.  But I keep
seeing these sizable patch sets.

I frankly don't care that it might not mesh well with how you code up
and validate changes internally, because it absolutely does NOT work
well for how bugs really get found and fixed upstream.

If you trickle changes in, the guilty change is obvious to spot and it
gets found before you do more development that depends upon that buggy
change.

Whereas if you patch bomb, someone has to do a lot of work and
bisecting to nail down the bad change.  And the bug might be so
fundamental in a patch that it also invalidates all the followon
work you did.

I really don't want to apply any of this stuff, to be honest with you.
I simply don't.  I keep giving guidelines and they keep getting
ignored.

Re: [net-next 00/36] bnx2x patch series

[David Miller]

From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 12 Aug 2009 21:19:22 +0300

> Here is a patch series for the bnx2x. This patch series also replace the
> FW, so
> it contains two big blobs - the new fw and the removal of the old one.
> Those
> patches do not contain anything but the ihex - the actually change to
> the driver
> is in patch number 2 which is small enough to fit the mailing list.
> 
> For those who wish to see all the patches, including the ihex, I also
> updated
> http://linux.broadcom.com/eilong/ to contain this patch series.
> 
> Please consider applying to net-next.

I've applied it all, but sincerely this is absolutely the last
time I'm taking in a patch bomb for a Broadcom ethernet driver.

If it's new stuff, keep it to ~10 patches.

If it's bug fixes outside of the merge window, keep it at
2 or 3 patches.

Post them very near to when you write them, so people have a chance of
actually reviewing your work (I guarentee I am the only non-Broadcom
person who looked over all 36 patches, or who ever will).

"Early and often" as it were...

Thanks.

Re: [net-next 00/36] bnx2x patch series

[Eilon Greenstein]

On Wed, 2009-08-12 at 23:09 -0700, David Miller wrote:
> From: "Eilon Greenstein" <eilong@broadcom.com>
> Date: Wed, 12 Aug 2009 21:19:22 +0300
> 
> > Here is a patch series for the bnx2x. This patch series also replace the
> > FW, so
> > it contains two big blobs - the new fw and the removal of the old one.
> > Those
> > patches do not contain anything but the ihex - the actually change to
> > the driver
> > is in patch number 2 which is small enough to fit the mailing list.
> > 
> > For those who wish to see all the patches, including the ihex, I also
> > updated
> > http://linux.broadcom.com/eilong/ to contain this patch series.
> > 
> > Please consider applying to net-next.
> 
> I've applied it all, but sincerely this is absolutely the last
> time I'm taking in a patch bomb for a Broadcom ethernet driver.
> 
> If it's new stuff, keep it to ~10 patches.
> 
> If it's bug fixes outside of the merge window, keep it at
> 2 or 3 patches.
> 
> Post them very near to when you write them, so people have a chance of
> actually reviewing your work (I guarentee I am the only non-Broadcom
> person who looked over all 36 patches, or who ever will).
> 
> "Early and often" as it were...
> 
Will do!

Thanks,
Eilon