From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Stephen Hemminger <shemminger@vyatta.com>,
Jarek Poplawski <jarkao2@gmail.com>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-2.6] pkt_sched: gen_estimator: add a new lock
Date: Tue, 08 Jun 2010 06:58:11 +0200 [thread overview]
Message-ID: <1275973091.2775.51.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTik7k__McJk8VCu0WP1RYEDHUfBJA4dyGYQTUmBV@mail.gmail.com>
Le mardi 08 juin 2010 à 09:00 +0800, Changli Gao a écrit :
> and I think gen_replace_estimator is expected to be an atomic operation.
>
> And gen_estimator_active() is also assumed to be called with RTNL locked.
>
My patch fixes a bug of new/kill operators, regardless of RTNL being
held or not. Its should be small enough to be included in linux-2.6.35.
If what you say is right, all gen_replace_estimator() /
gen_estimator_active() callers should still holds RTNL.
I didnt change this part.
If you believe one caller doesnt hold RTNL, please submit another patch.
Then, in net-next-2.6, we can probably cleanup this to remove RTNL
requirement if possible for gen_replace_estimator() /
gen_estimator_active()
Yes, it sounds a bit difficult (three patches instead of a single one),
but this is the how things should be done, step by step.
next prev parent reply other threads:[~2010-06-08 4:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 14:32 [PATCH net-next-2.6] pkt_sched: gen_estimator: kill est_lock rwlock Eric Dumazet
2010-06-07 14:53 ` Changli Gao
2010-06-07 15:30 ` Eric Dumazet
2010-06-07 15:55 ` Eric Dumazet
2010-06-07 16:56 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2010-06-07 17:18 ` [PATCH net-2.6] pkt_sched: gen_estimator: add a new lock Eric Dumazet
2010-06-08 1:00 ` Changli Gao
2010-06-08 4:30 ` Eric Dumazet
2010-06-08 4:57 ` Changli Gao
2010-06-08 4:58 ` Eric Dumazet [this message]
2010-06-08 5:20 ` Changli Gao
2010-06-08 5:39 ` Eric Dumazet
2010-06-09 9:39 ` [PATCH net-2.6 v2] " Eric Dumazet
2010-06-09 11:33 ` Jarek Poplawski
2010-06-09 11:55 ` Eric Dumazet
2010-06-11 5:54 ` David Miller
2010-06-08 12:15 ` [PATCH net-next-2.6 v2] pkt_sched: gen_estimator: kill est_lock rwlock Jarek Poplawski
2010-06-08 12:27 ` Eric Dumazet
2010-06-08 12:40 ` Jarek Poplawski
2010-06-08 19:29 ` Jarek Poplawski
2010-06-08 19:45 ` Eric Dumazet
2010-06-08 20:24 ` Jarek Poplawski
2010-06-08 20:52 ` Eric Dumazet
2010-06-08 21:18 ` Jarek Poplawski
2010-06-09 6:13 ` pkt_sched: gen_estimator: more fuel for Jarek and Changli Eric Dumazet
2010-06-09 6:51 ` Jarek Poplawski
2010-06-09 7:36 ` Eric Dumazet
2010-06-09 8:14 ` Jarek Poplawski
2010-06-09 9:40 ` [PATCH] pkt_sched: gen_kill_estimator() rcu fixes Eric Dumazet
2010-06-09 9:56 ` Eric Dumazet
2010-06-09 10:41 ` Jarek Poplawski
2010-06-09 12:09 ` Eric Dumazet
2010-06-09 12:50 ` Jarek Poplawski
2010-06-09 13:05 ` Eric Dumazet
2010-06-12 1:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275973091.2775.51.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox