public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Kristian Larsson <kristian@spritelink.net>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: pktgen IP address stepping
Date: Thu, 16 Dec 2010 10:02:12 -0800	[thread overview]
Message-ID: <1292522532.29894.33.camel@Joe-Laptop> (raw)
In-Reply-To: <20101216172800.GA8404@spritelink.se>

On Thu, 2010-12-16 at 18:28 +0100, Kristian Larsson wrote:
> This patch adds the ability to set the step rate at which the source
> or destination IP address is increased when src_min / src_max or
> dst_min / dst_max is used with pktgen.
> Usage is simple, two new parameters:
>   src_step X
>   dst_step X
> where X is a positive integer (or actually an unsigned long long).
[]
> Looking forward to any feedback and / or suggestions.

I suggest using actual ipv4 addresses (and ipv6 if you ever
need it) as increment/mask.

For your current use, __u32 would work fine.

trivia:

pr_<foo> calls are already prefixed with pktgen via pr_fmt,
you don't need to add it to the format string.



  parent reply	other threads:[~2010-12-16 18:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16 17:28 pktgen IP address stepping Kristian Larsson
2010-12-16 17:44 ` David Miller
2010-12-16 18:27   ` Kristian Larsson
2010-12-16 18:34     ` David Miller
2010-12-16 18:02 ` Joe Perches [this message]
2010-12-16 18:30   ` Kristian Larsson
2010-12-16 19:02     ` [PATCH net-next] pktgen: Remove unnecessary prefix from pr_<level> Joe Perches
2010-12-20 18:30       ` David Miller
2010-12-16 19:18     ` pktgen IP address stepping Joe Perches
2010-12-16 20:34       ` Kristian Larsson
2010-12-16 21:11   ` Kristian Larsson
2010-12-16 21:22     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292522532.29894.33.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=kristian@spritelink.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox