Re: pktgen IP address stepping

[Joe Perches <joe@perches.com>]

On Thu, 2010-12-16 at 22:11 +0100, Kristian Larsson wrote:
> On Thu, Dec 16, 2010 at 10:02:12AM -0800, Joe Perches wrote:
> > pr_<foo> calls are already prefixed with pktgen via pr_fmt,
> > you don't need to add it to the format string.
> I can see at least two different cases of debug statements;
>     if (debug)
>         pr_info("Delay set at: %llu ns\n", pkt_dev->delay);
>     if (debug)
>         printk(KERN_DEBUG "pktgen: dst_min set to: %s\n",
>                pkt_dev->dst_min);
> what's the reasoning behind using one or the other?

pr_info(fmt, ...)	emits at KERN_INFO level and uses pr_fmt(fmt)
printk(KERN_DEBUG	emits at KERN_DEBUG level and doesn't use pr_fmt
pr_debug(fmt, ...)	does use pr_fmt and is optionally compiled.

I can't say why the author decided to use a info level output
for the delay set message.  Maybe that person doesn't like to see
KERN_DEBUG messages.

cheers, Joe