From: Joe Perches <joe@perches.com>
To: Kristian Larsson <kristian@spritelink.net>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: [PATCH net-next] pktgen: Remove unnecessary prefix from pr_<level>
Date: Thu, 16 Dec 2010 11:02:33 -0800 [thread overview]
Message-ID: <1292526153.29894.37.camel@Joe-Laptop> (raw)
In-Reply-To: <20101216183004.GC8404@spritelink.se>
Remove "pktgen: " prefix string from one pr_info.
pr_fmt adds it, so this is a duplicate.
Signed-off-by: Joe Perches <joe@perches.com>
---
> > trivia:
> > pr_<foo> calls are already prefixed with pktgen via pr_fmt,
> > you don't need to add it to the format string.
> Same thing here, will look over it. I think I copied most of this
> from some other part of pktgen.c :)
net/core/pktgen.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 18fe20d..a9e7fc4 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3553,8 +3553,7 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev)
break;
default: /* Drivers are not supposed to return other values! */
if (net_ratelimit())
- pr_info("pktgen: %s xmit error: %d\n",
- pkt_dev->odevname, ret);
+ pr_info("%s xmit error: %d\n", pkt_dev->odevname, ret);
pkt_dev->errors++;
/* fallthru */
case NETDEV_TX_LOCKED:
next prev parent reply other threads:[~2010-12-16 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 17:28 pktgen IP address stepping Kristian Larsson
2010-12-16 17:44 ` David Miller
2010-12-16 18:27 ` Kristian Larsson
2010-12-16 18:34 ` David Miller
2010-12-16 18:02 ` Joe Perches
2010-12-16 18:30 ` Kristian Larsson
2010-12-16 19:02 ` Joe Perches [this message]
2010-12-20 18:30 ` [PATCH net-next] pktgen: Remove unnecessary prefix from pr_<level> David Miller
2010-12-16 19:18 ` pktgen IP address stepping Joe Perches
2010-12-16 20:34 ` Kristian Larsson
2010-12-16 21:11 ` Kristian Larsson
2010-12-16 21:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292526153.29894.37.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=kristian@spritelink.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox