public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Lu <shawn.lu@ericsson.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, xiaoclu@gmail.com
Subject: [PATCH] tcp: RST: binding oif to iif for tcp v4
Date: Fri, 3 Feb 2012 12:16:52 -0800	[thread overview]
Message-ID: <1328300212-18836-1-git-send-email-shawn.lu@ericsson.com> (raw)

Binding RST packet outgoing interface to incomming interface
for tcp v4. This has few benefits:
1. tcp_v6_send_reset already did that.
2. This helps tcp connect with SO_BINDTODEVICE set. When connection
is lost, we still able to sending out RST using same interface.
3. limit RST traffic in ingress interface reduce the impact of
RST attack.

Signed-off-by: Shawn Lu <shawn.lu@ericsson.com>
---
 net/ipv4/tcp_ipv4.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 90e4793..994b1ea 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -676,6 +676,7 @@ static void tcp_v4_send_reset(struct sock *sk, struct sk_buff *skb)
 				      arg.iov[0].iov_len, IPPROTO_TCP, 0);
 	arg.csumoffset = offsetof(struct tcphdr, check) / 2;
 	arg.flags = (sk && inet_sk(sk)->transparent) ? IP_REPLY_ARG_NOSRCCHECK : 0;
+	arg.bound_dev_if = inet_iif(skb);
 
 	net = dev_net(skb_dst(skb)->dev);
 	arg.tos = ip_hdr(skb)->tos;
-- 
1.7.0.4

             reply	other threads:[~2012-02-03 20:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03 20:16 Shawn Lu [this message]
2012-02-03 21:31 ` [PATCH] tcp: RST: binding oif to iif for tcp v4 Eric Dumazet
2012-02-03 21:39   ` Ben Greear
2012-02-03 21:56     ` Shawn Lu
2012-02-03 21:43   ` Shawn Lu
2012-02-04  7:44     ` Eric Dumazet
2012-02-04  8:06     ` Eric Dumazet
2012-02-04 18:15       ` Shawn Lu
2012-02-04 18:29         ` Eric Dumazet
2012-02-04 18:42           ` Shawn Lu
2012-02-04 19:09             ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328300212-18836-1-git-send-email-shawn.lu@ericsson.com \
    --to=shawn.lu@ericsson.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiaoclu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox