public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shawn Lu <shawn.lu@ericsson.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"xiaoclu@gmail.com" <xiaoclu@gmail.com>
Subject: RE: [PATCH] tcp: RST: binding oif to iif for tcp v4
Date: Sat, 04 Feb 2012 20:09:50 +0100	[thread overview]
Message-ID: <1328382590.2731.45.camel@edumazet-laptop> (raw)
In-Reply-To: <62162DF05402B341B3DB59932A1FA992B5B5C9FCFC@EUSAACMS0702.eamcs.ericsson.se>

Le samedi 04 février 2012 à 13:42 -0500, Shawn Lu a écrit :
> Eric:
> 
> Yes, you are right.  It helps if we do as your suggested.
> 
> Do you want to send out a patch to address this? 
> 

All I was saying was that if sk is not NULL, it must have precedence.

So you could prepare/submit a patch amended by what I said, so that we
can make progress ?

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 90e4793..ca2348f 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -676,6 +676,7 @@ static void tcp_v4_send_reset(struct sock *sk, struct sk_buff *skb)
 				      arg.iov[0].iov_len, IPPROTO_TCP, 0);
 	arg.csumoffset = offsetof(struct tcphdr, check) / 2;
 	arg.flags = (sk && inet_sk(sk)->transparent) ? IP_REPLY_ARG_NOSRCCHECK : 0;
+	arg.bound_dev_if = sk ? sk->sk_bound_dev_if : inet_iif(skb);
 
 	net = dev_net(skb_dst(skb)->dev);
 	arg.tos = ip_hdr(skb)->tos;

      reply	other threads:[~2012-02-04 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03 20:16 [PATCH] tcp: RST: binding oif to iif for tcp v4 Shawn Lu
2012-02-03 21:31 ` Eric Dumazet
2012-02-03 21:39   ` Ben Greear
2012-02-03 21:56     ` Shawn Lu
2012-02-03 21:43   ` Shawn Lu
2012-02-04  7:44     ` Eric Dumazet
2012-02-04  8:06     ` Eric Dumazet
2012-02-04 18:15       ` Shawn Lu
2012-02-04 18:29         ` Eric Dumazet
2012-02-04 18:42           ` Shawn Lu
2012-02-04 19:09             ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328382590.2731.45.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.lu@ericsson.com \
    --cc=xiaoclu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox