From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shawn Lu <shawn.lu@ericsson.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xiaoclu@gmail.com" <xiaoclu@gmail.com>
Subject: RE: [PATCH] tcp: RST: binding oif to iif for tcp v4
Date: Sat, 04 Feb 2012 08:44:23 +0100 [thread overview]
Message-ID: <1328341463.2480.12.camel@edumazet-laptop> (raw)
In-Reply-To: <62162DF05402B341B3DB59932A1FA992B5B5C9FB94@EUSAACMS0702.eamcs.ericsson.se>
Le vendredi 03 février 2012 à 16:43 -0500, Shawn Lu a écrit :
> See inline.
> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
> Le vendredi 03 février 2012 à 12:16 -0800, Shawn Lu a écrit :
> > Binding RST packet outgoing interface to incomming interface for tcp
> > v4. This has few benefits:
> > 1. tcp_v6_send_reset already did that.
>
> I dont think so. ipv6 makes no special provision for RST.
> [shawn LU] it's in tcp_v6_send_response line 899 of tcp_ipv6.c
> fl6.flowi6_oif = inet6_iif(skb);
>
tcp_v6_send_response() is used to send RST _and_ ACK
Its not reserved to RST. Thats why I said "no _special_ provision for
RST"
I repeat my question :
Why do you believe only RST should be handled in a different manner than
other TCP messages ?
If we decide to break asymmetric routing, we should do it completely and
document it.
It might already be broken for IPv6 and nobody cared / noticed.
next prev parent reply other threads:[~2012-02-04 7:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 20:16 [PATCH] tcp: RST: binding oif to iif for tcp v4 Shawn Lu
2012-02-03 21:31 ` Eric Dumazet
2012-02-03 21:39 ` Ben Greear
2012-02-03 21:56 ` Shawn Lu
2012-02-03 21:43 ` Shawn Lu
2012-02-04 7:44 ` Eric Dumazet [this message]
2012-02-04 8:06 ` Eric Dumazet
2012-02-04 18:15 ` Shawn Lu
2012-02-04 18:29 ` Eric Dumazet
2012-02-04 18:42 ` Shawn Lu
2012-02-04 19:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328341463.2480.12.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shawn.lu@ericsson.com \
--cc=xiaoclu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox