* [PATCH] netem: fix unwanted reordering
@ 2012-02-16 5:49 Eric Dumazet
2012-02-16 6:13 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2012-02-16 5:49 UTC (permalink / raw)
To: David Miller; +Cc: netdev
commit 50612537e9 (netem: fix classful handling) added in typo in
netem_dequeue() :
After checking skb at the head of tfifo queue for time constraints, it
dequeues tail skb, thus adding unwanted reordering.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/sched/sch_netem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index e83d61c..1db8ff0 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -501,7 +501,7 @@ tfifo_dequeue:
/* if more time remaining? */
if (cb->time_to_send <= psched_get_time()) {
- skb = qdisc_dequeue_tail(sch);
+ skb = qdisc_dequeue_head(sch);
if (unlikely(!skb))
goto qdisc_dequeue;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netem: fix unwanted reordering
2012-02-16 5:49 [PATCH] netem: fix unwanted reordering Eric Dumazet
@ 2012-02-16 6:13 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2012-02-16 6:13 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Le jeudi 16 février 2012 à 06:49 +0100, Eric Dumazet a écrit :
> commit 50612537e9 (netem: fix classful handling) added in typo in
> netem_dequeue() :
>
> After checking skb at the head of tfifo queue for time constraints, it
> dequeues tail skb, thus adding unwanted reordering.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> net/sched/sch_netem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Please dont apply this patch, there is a 2nd issue I must fix as well
(qdisc stats are updated twice)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-16 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-16 5:49 [PATCH] netem: fix unwanted reordering Eric Dumazet
2012-02-16 6:13 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox