From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Tom Herbert <therbert@google.com>
Subject: Re: [PATCH 1/5] tcp: heed result of security_inet_conn_request() in tcp_v6_conn_request()
Date: Sun, 24 Jun 2012 09:36:57 +0200 [thread overview]
Message-ID: <1340523417.23933.4.camel@edumazet-glaptop> (raw)
In-Reply-To: <1340515324-2152-1-git-send-email-ncardwell@google.com>
On Sun, 2012-06-24 at 01:22 -0400, Neal Cardwell wrote:
> If security_inet_conn_request() returns non-zero then TCP/IPv6 should
> drop the request, just as in TCP/IPv4 and DCCP in both IPv4 and IPv6.
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> ---
> net/ipv6/tcp_ipv6.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 3a9aec2..9df64a5 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1212,7 +1212,8 @@ have_isn:
> tcp_rsk(req)->snt_isn = isn;
> tcp_rsk(req)->snt_synack = tcp_time_stamp;
>
> - security_inet_conn_request(sk, skb, req);
> + if (security_inet_conn_request(sk, skb, req))
> + goto drop_and_release;
>
> if (tcp_v6_send_synack(sk, req,
> (struct request_values *)&tmp_ext,
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2012-06-24 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 5:22 [PATCH 1/5] tcp: heed result of security_inet_conn_request() in tcp_v6_conn_request() Neal Cardwell
2012-06-24 5:22 ` [PATCH 2/5] tcp: fix inet6_csk_route_req() for link-local addresses Neal Cardwell
2012-06-24 7:37 ` Eric Dumazet
2012-06-24 5:22 ` [PATCH 3/5] tcp: pass fl6 to inet6_csk_route_req() Neal Cardwell
2012-06-24 5:22 ` [PATCH 4/5] tcp: use inet6_csk_route_req() in tcp_v6_send_synack() Neal Cardwell
2012-06-24 5:22 ` [PATCH 5/5] tcp: plug dst leak in tcp_v6_conn_request() Neal Cardwell
2012-06-24 6:44 ` Eric Dumazet
2012-06-24 7:41 ` Eric Dumazet
2012-06-24 17:12 ` Neal Cardwell
2012-06-25 6:35 ` Eric Dumazet
2012-06-25 23:06 ` David Miller
2012-06-24 7:36 ` Eric Dumazet [this message]
2012-06-25 23:05 ` [PATCH 1/5] tcp: heed result of security_inet_conn_request() " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340523417.23933.4.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox