public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Tom Herbert <therbert@google.com>
Subject: Re: [PATCH 5/5] tcp: plug dst leak in tcp_v6_conn_request()
Date: Sun, 24 Jun 2012 09:41:18 +0200	[thread overview]
Message-ID: <1340523678.23933.11.camel@edumazet-glaptop> (raw)
In-Reply-To: <1340515324-2152-5-git-send-email-ncardwell@google.com>

On Sun, 2012-06-24 at 01:22 -0400, Neal Cardwell wrote:
> The code in tcp_v6_conn_request() was implicitly assuming that
> tcp_v6_send_synack() would take care of dst_release(), much as
> tcp_v4_send_synack() already does. This resulted in
> tcp_v6_conn_request() leaking a dst if sysctl_tw_recycle is enabled.
> 
> This commit restructures tcp_v6_send_synack() so that it accepts a dst
> pointer and takes care of releasing the dst that is passed in, to plug
> the leak and avoid future surprises by bringing the IPv6 behavior in
> line with the IPv4 side.

I feel a bit uncomfortable to send a mix of 3 patches to fix one bug.

Could you instead send pure fix (fixing dst leak) for net tree ?

Then, when fix is incorporated in net-next, send the cleanups ?

This also clashes with this pending work, so it would ease things if you
can respin the cleanups for net-next

http://patchwork.ozlabs.org/patch/166737/

Thanks !

  parent reply	other threads:[~2012-06-24  7:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-24  5:22 [PATCH 1/5] tcp: heed result of security_inet_conn_request() in tcp_v6_conn_request() Neal Cardwell
2012-06-24  5:22 ` [PATCH 2/5] tcp: fix inet6_csk_route_req() for link-local addresses Neal Cardwell
2012-06-24  7:37   ` Eric Dumazet
2012-06-24  5:22 ` [PATCH 3/5] tcp: pass fl6 to inet6_csk_route_req() Neal Cardwell
2012-06-24  5:22 ` [PATCH 4/5] tcp: use inet6_csk_route_req() in tcp_v6_send_synack() Neal Cardwell
2012-06-24  5:22 ` [PATCH 5/5] tcp: plug dst leak in tcp_v6_conn_request() Neal Cardwell
2012-06-24  6:44   ` Eric Dumazet
2012-06-24  7:41   ` Eric Dumazet [this message]
2012-06-24 17:12     ` Neal Cardwell
2012-06-25  6:35       ` Eric Dumazet
2012-06-25 23:06       ` David Miller
2012-06-24  7:36 ` [PATCH 1/5] tcp: heed result of security_inet_conn_request() " Eric Dumazet
2012-06-25 23:05   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340523678.23933.11.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox