From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Ling Ma <ling.ma.program@gmail.com>
Subject: Re: [PATCH net-next] net: move inet_dport/inet_num in sock_common
Date: Tue, 27 Nov 2012 09:23:20 -0800 [thread overview]
Message-ID: <1354037000.2116.19.camel@joe-AO722> (raw)
In-Reply-To: <1354028815.14302.35.camel@edumazet-glaptop>
On Tue, 2012-11-27 at 07:06 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> commit 68835aba4d9b (net: optimize INET input path further)
> moved some fields used for tcp/udp sockets lookup in the first cache
> line of struct sock_common.
[]
> diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
> index 5e11905..196ede4 100644
> --- a/include/linux/ipv6.h
> +++ b/include/linux/ipv6.h
> @@ -365,19 +365,21 @@ static inline struct raw6_sock *raw6_sk(const struct sock *sk)
> #endif /* IS_ENABLED(CONFIG_IPV6) */
>
> #define INET6_MATCH(__sk, __net, __hash, __saddr, __daddr, __ports, __dif)\
> + (((__sk)->sk_hash == (__hash)) && \
> + ((*((__portpair *)&(inet_sk(__sk)->inet_dport))) == (__ports)) && \
> + ((__sk)->sk_family == AF_INET6) && \
Perhaps these could be |'d together to avoid the test/jump
after each comparison by using some bit operations instead.
> + ipv6_addr_equal(&inet6_sk(__sk)->daddr, (__saddr)) && \
> + ipv6_addr_equal(&inet6_sk(__sk)->rcv_saddr, (__daddr)) && \
> + (!((__sk)->sk_bound_dev_if) || ((__sk)->sk_bound_dev_if == (__dif))) && \
> + net_eq(sock_net(__sk), (__net)))
next prev parent reply other threads:[~2012-11-27 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 15:06 [PATCH net-next] net: move inet_dport/inet_num in sock_common Eric Dumazet
2012-11-27 17:23 ` Joe Perches [this message]
2012-11-27 21:24 ` Eric Dumazet
2012-11-28 2:23 ` Joe Perches
2012-11-28 3:12 ` Ben Hutchings
2012-11-28 3:31 ` Joe Perches
2012-11-28 3:55 ` Ben Hutchings
2012-11-28 4:11 ` Eric Dumazet
2012-11-28 11:27 ` Eric Dumazet
2012-11-28 12:56 ` [PATCH v2 " Eric Dumazet
2012-11-28 16:48 ` David Miller
2012-11-28 17:02 ` David Miller
2012-11-28 17:18 ` Eric Dumazet
2012-11-28 18:20 ` Eric Dumazet
2012-11-27 19:05 ` [PATCH " Ben Hutchings
2012-11-27 21:23 ` Eric Dumazet
2012-11-28 3:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354037000.2116.19.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ling.ma.program@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox