From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Ling Ma <ling.ma.program@gmail.com>,
Joe Perches <joe@perches.com>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH v2 net-next] net: move inet_dport/inet_num in sock_common
Date: Wed, 28 Nov 2012 10:20:17 -0800 [thread overview]
Message-ID: <1354126817.14302.451.camel@edumazet-glaptop> (raw)
In-Reply-To: <1354107378.14302.149.camel@edumazet-glaptop>
On Wed, 2012-11-28 at 04:56 -0800, Eric Dumazet wrote:
> +#define INET_MATCH(__sk, __net, __cookie, __saddr, __daddr, __ports, __dif) \
> + ((inet_sk(__sk)->inet_portpair == (__ports)) && \
> + (inet_sk(__sk)->inet_addrpair == (__addrpair)) && \
> + (!(__sk)->sk_bound_dev_if || \
> + ((__sk)->sk_bound_dev_if == (__dif))) && \
> + net_eq(sock_net(__sk), (__net)))
> +#define INET_TW_MATCH(__sk, __net, __cookie, __saddr, __daddr, __ports, __dif)\
> + ((inet_twsk(__sk)->tw_portpair == (__ports)) && \
> + (inet_twsk(__sk)->tw_addrpair == (__addrpair)) && \
> + (!(__sk)->sk_bound_dev_if || \
> + ((__sk)->sk_bound_dev_if == (__dif))) && \
> + net_eq(sock_net(__sk), (__net)))
Last minute change in a param name __cookie / __addrpair
I reverted this change as the 32bit part is not using the 'cookie', so
keeping __the cookie name makes sense.
I'll fix this and add performance results in the changelog.
next prev parent reply other threads:[~2012-11-28 18:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 15:06 [PATCH net-next] net: move inet_dport/inet_num in sock_common Eric Dumazet
2012-11-27 17:23 ` Joe Perches
2012-11-27 21:24 ` Eric Dumazet
2012-11-28 2:23 ` Joe Perches
2012-11-28 3:12 ` Ben Hutchings
2012-11-28 3:31 ` Joe Perches
2012-11-28 3:55 ` Ben Hutchings
2012-11-28 4:11 ` Eric Dumazet
2012-11-28 11:27 ` Eric Dumazet
2012-11-28 12:56 ` [PATCH v2 " Eric Dumazet
2012-11-28 16:48 ` David Miller
2012-11-28 17:02 ` David Miller
2012-11-28 17:18 ` Eric Dumazet
2012-11-28 18:20 ` Eric Dumazet [this message]
2012-11-27 19:05 ` [PATCH " Ben Hutchings
2012-11-27 21:23 ` Eric Dumazet
2012-11-28 3:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354126817.14302.451.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=ling.ma.program@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox