From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, ling.ma.program@gmail.com,
joe@perches.com, bhutchings@solarflare.com
Subject: Re: [PATCH v2 net-next] net: move inet_dport/inet_num in sock_common
Date: Wed, 28 Nov 2012 12:02:43 -0500 (EST) [thread overview]
Message-ID: <20121128.120243.1053933388686939425.davem@davemloft.net> (raw)
In-Reply-To: <20121128.114835.1005932954047935079.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 28 Nov 2012 11:48:35 -0500 (EST)
> I like this a lot, applied, thanks Eric!
And I'd like it even more if it was build tested :-/
net/ipv4/inet_hashtables.c: In function ‘__inet_lookup_established’:
net/ipv4/inet_hashtables.c:242:7: error: expected expression before ‘)’ token
net/ipv4/inet_hashtables.c:246:8: error: expected expression before ‘)’ token
net/ipv4/inet_hashtables.c:267:7: error: expected expression before ‘)’ token
net/ipv4/inet_hashtables.c:274:8: error: expected expression before ‘)’ token
net/ipv4/inet_hashtables.c:226:2: warning: unused variable ‘acookie’ [-Wunused-variable]
net/ipv4/inet_hashtables.c: In function ‘__inet_check_established’:
net/ipv4/inet_hashtables.c:326:7: error: expected expression before ‘)’ token
net/ipv4/inet_hashtables.c:341:7: error: expected expression before ‘)’ token
net/ipv4/inet_hashtables.c:307:2: warning: unused variable ‘acookie’ [-Wunused-variable]
net/ipv4/inet_hashtables.c:306:6: warning: unused variable ‘dif’ [-Wunused-variable]
This is with gcc-4.7.2-2 on Fedora 17 on an allmodconfig build.
next prev parent reply other threads:[~2012-11-28 17:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 15:06 [PATCH net-next] net: move inet_dport/inet_num in sock_common Eric Dumazet
2012-11-27 17:23 ` Joe Perches
2012-11-27 21:24 ` Eric Dumazet
2012-11-28 2:23 ` Joe Perches
2012-11-28 3:12 ` Ben Hutchings
2012-11-28 3:31 ` Joe Perches
2012-11-28 3:55 ` Ben Hutchings
2012-11-28 4:11 ` Eric Dumazet
2012-11-28 11:27 ` Eric Dumazet
2012-11-28 12:56 ` [PATCH v2 " Eric Dumazet
2012-11-28 16:48 ` David Miller
2012-11-28 17:02 ` David Miller [this message]
2012-11-28 17:18 ` Eric Dumazet
2012-11-28 18:20 ` Eric Dumazet
2012-11-27 19:05 ` [PATCH " Ben Hutchings
2012-11-27 21:23 ` Eric Dumazet
2012-11-28 3:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128.120243.1053933388686939425.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=ling.ma.program@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox