Netdev List
 help / color / mirror / Atom feed
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
To: <netdev@vger.kernel.org>
Cc: nandini sharma <nandini.sharma@st.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: [PATCH (net.git) 2/4] stmmac: fix LPI TW timer value to 20.5us.
Date: Tue, 26 Aug 2014 09:16:21 +0200	[thread overview]
Message-ID: <1409037383-3213-3-git-send-email-peppe.cavallaro@st.com> (raw)
In-Reply-To: <1409037383-3213-1-git-send-email-peppe.cavallaro@st.com>

From: nandini sharma <nandini.sharma@st.com>

The value for LPI TW timer has to be updated to 0x1E that is the hardcoded value
of 20.5us and it will apply to all EEE enabled Remote PHYs.
Disadvantage is for PHY's that support lesser wakeup time but we can accept it
waiting to implement LLDP to negotiate the Wakeup time of Remote PHY.

Signed-off-by: nandini sharma <nandini.sharma@st.com>
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
 drivers/net/ethernet/stmicro/stmmac/common.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
index a464e8c..9f3e8b4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/common.h
+++ b/drivers/net/ethernet/stmicro/stmmac/common.h
@@ -287,7 +287,7 @@ struct dma_features {
 
 /* Default LPI timers */
 #define STMMAC_DEFAULT_LIT_LS	0x3E8
-#define STMMAC_DEFAULT_TWT_LS	0x0
+#define STMMAC_DEFAULT_TWT_LS	0x1E
 
 #define STMMAC_CHAIN_MODE	0x1
 #define STMMAC_RING_MODE	0x2
-- 
1.7.4.4

  parent reply	other threads:[~2014-08-26  7:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  7:16 [PATCH (net.git) 0/4] stmmac EEE fixes Giuseppe Cavallaro
2014-08-26  7:16 ` [PATCH (net.git) 1/4] stmmac: fix the EEE LPI Macro definitions Giuseppe Cavallaro
2014-08-26  7:16 ` Giuseppe Cavallaro [this message]
2014-08-26  7:16 ` [PATCH (net.git) 3/4] stmmac: never check EEE in case of a switch is attached Giuseppe Cavallaro
2014-08-27 23:28   ` David Miller
2014-08-26  7:16 ` [PATCH (net.git) 4/4] stmmac: fix PLS bit setting when EEE is active Giuseppe Cavallaro
  -- strict thread matches above, loose matches on Subject: below --
2014-08-28  6:11 [PATCH (net.git) 0/4 (v2)] stmmac EEE fixes Giuseppe Cavallaro
2014-08-28  6:11 ` [PATCH (net.git) 2/4] stmmac: fix LPI TW timer value to 20.5us Giuseppe Cavallaro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409037383-3213-3-git-send-email-peppe.cavallaro@st.com \
    --to=peppe.cavallaro@st.com \
    --cc=nandini.sharma@st.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox