Netdev List
 help / color / mirror / Atom feed
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
To: <netdev@vger.kernel.org>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	nandini sharma <nandini.sharma@st.com>
Subject: [PATCH (net.git) 4/4] stmmac: fix PLS bit setting when EEE is active
Date: Tue, 26 Aug 2014 09:16:23 +0200	[thread overview]
Message-ID: <1409037383-3213-5-git-send-email-peppe.cavallaro@st.com> (raw)
In-Reply-To: <1409037383-3213-1-git-send-email-peppe.cavallaro@st.com>

In case of PLS is active the PLS (PHY Link Status) bit in
the Reg12 has to be set to allow the MAC to asserts the LPI
pattern when the link is ok.

Signed-off-by: nandini sharma <nandini.sharma@st.com>
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 48a112f..5b5bbc3 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -321,10 +321,9 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
 			priv->hw->mac->set_eee_timer(priv->hw,
 						     STMMAC_DEFAULT_LIT_LS,
 						     tx_lpi_timer);
-		} else
-			/* Set HW EEE according to the speed */
-			priv->hw->mac->set_eee_pls(priv->hw,
-						   priv->phydev->link);
+		}
+		/* Set HW EEE according to the speed */
+		priv->hw->mac->set_eee_pls(priv->hw, priv->phydev->link);
 
 		pr_debug("stmmac: Energy-Efficient Ethernet initialized\n");
 
-- 
1.7.4.4

  parent reply	other threads:[~2014-08-26  7:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  7:16 [PATCH (net.git) 0/4] stmmac EEE fixes Giuseppe Cavallaro
2014-08-26  7:16 ` [PATCH (net.git) 1/4] stmmac: fix the EEE LPI Macro definitions Giuseppe Cavallaro
2014-08-26  7:16 ` [PATCH (net.git) 2/4] stmmac: fix LPI TW timer value to 20.5us Giuseppe Cavallaro
2014-08-26  7:16 ` [PATCH (net.git) 3/4] stmmac: never check EEE in case of a switch is attached Giuseppe Cavallaro
2014-08-27 23:28   ` David Miller
2014-08-26  7:16 ` Giuseppe Cavallaro [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-08-28  6:11 [PATCH (net.git) 0/4 (v2)] stmmac EEE fixes Giuseppe Cavallaro
2014-08-28  6:11 ` [PATCH (net.git) 4/4] stmmac: fix PLS bit setting when EEE is active Giuseppe Cavallaro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409037383-3213-5-git-send-email-peppe.cavallaro@st.com \
    --to=peppe.cavallaro@st.com \
    --cc=nandini.sharma@st.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox