From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
To: <netdev@vger.kernel.org>
Cc: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Subject: [PATCH (net.git) 3/4] stmmac: never check EEE in case of a switch is attached
Date: Tue, 26 Aug 2014 09:16:22 +0200 [thread overview]
Message-ID: <1409037383-3213-4-git-send-email-peppe.cavallaro@st.com> (raw)
In-Reply-To: <1409037383-3213-1-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
This patch is to skip the EEE initialisation when the stmmac
is using a switch (with a fixed phy support).
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 51a89d4..48a112f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -276,6 +276,7 @@ static void stmmac_eee_ctrl_timer(unsigned long arg)
bool stmmac_eee_init(struct stmmac_priv *priv)
{
bool ret = false;
+ char *phy_bus_name = priv->plat->phy_bus_name;
/* Using PCS we cannot dial with the phy registers at this stage
* so we do not support extra feature like EEE.
@@ -284,6 +285,10 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
(priv->pcs == STMMAC_PCS_RTBI))
goto out;
+ /* Never init EEE in case of a switch is attached */
+ if (phy_bus_name && (!strcmp(phy_bus_name, "fixed")))
+ goto out;
+
/* MAC core supports the EEE feature. */
if (priv->dma_cap.eee) {
int tx_lpi_timer = priv->tx_lpi_timer;
--
1.7.4.4
next prev parent reply other threads:[~2014-08-26 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 7:16 [PATCH (net.git) 0/4] stmmac EEE fixes Giuseppe Cavallaro
2014-08-26 7:16 ` [PATCH (net.git) 1/4] stmmac: fix the EEE LPI Macro definitions Giuseppe Cavallaro
2014-08-26 7:16 ` [PATCH (net.git) 2/4] stmmac: fix LPI TW timer value to 20.5us Giuseppe Cavallaro
2014-08-26 7:16 ` Giuseppe Cavallaro [this message]
2014-08-27 23:28 ` [PATCH (net.git) 3/4] stmmac: never check EEE in case of a switch is attached David Miller
2014-08-26 7:16 ` [PATCH (net.git) 4/4] stmmac: fix PLS bit setting when EEE is active Giuseppe Cavallaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409037383-3213-4-git-send-email-peppe.cavallaro@st.com \
--to=peppe.cavallaro@st.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox