Re: [PATCH v3 net-next 1/3] ipv4: rename ip_options_echo to __ip_options_echo()

[Joe Perches <joe@perches.com>]

On Thu, 2014-09-25 at 13:14 -0700, Eric Dumazet wrote:
> ip_options_echo() assumes struct ip_options is provided in &IPCB(skb)->opt
> Lets break this assumption, but provide a helper to not change all call points.
[]
> diff --git a/include/net/ip.h b/include/net/ip.h
[]
> @@ -511,7 +513,14 @@ int ip_forward(struct sk_buff *skb);
>   
>  void ip_options_build(struct sk_buff *skb, struct ip_options *opt,
>  		      __be32 daddr, struct rtable *rt, int is_frag);
> -int ip_options_echo(struct ip_options *dopt, struct sk_buff *skb);
> +
> +int __ip_options_echo(struct ip_options *dopt, struct sk_buff *skb,
> +		      const struct ip_options *sopt);

Thanks Eric.

Unrelated:

I wonder how much effort, if any, should be made to convert
struct sk_buff * to const struct sk_buff * where appropriate.

For instance:

This __ip_options_echo could use const struct sk_buff *skb
if fib_compute_spec_dst was changed to const struct sk_buff *skb.