From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Christoph Paasch <christoph.paasch@uclouvain.be>
Subject: Re: [PATCH v3 net-next 1/3] ipv4: rename ip_options_echo to __ip_options_echo()
Date: Fri, 26 Sep 2014 01:08:05 -0700 [thread overview]
Message-ID: <1411718885.19443.2.camel@joe-AO725> (raw)
In-Reply-To: <alpine.DEB.2.02.1409260724520.2078@localhost6.localdomain6>
On Fri, 2014-09-26 at 07:29 +0200, Julia Lawall wrote:
> On Thu, 25 Sep 2014, Joe Perches wrote:
> > On Thu, 2014-09-25 at 13:38 -0700, Eric Dumazet wrote:
> > > On Thu, 2014-09-25 at 13:30 -0700, Joe Perches wrote:
[]
> > > > I wonder how much effort, if any, should be made to convert
> > > > struct sk_buff * to const struct sk_buff * where appropriate.
> > > >
> > > > For instance:n
> > > >
> > > > This __ip_options_echo could use const struct sk_buff *skb
> > > > if fib_compute_spec_dst was changed to const struct sk_buff *skb.
> > >
> > > Well, this seems something certainly doable, as a follow up ;)
> >
> > It's doable, but it seems a non-trivial inspection task.
> >
> > I believe coccinelle does not have the ability to automate this.
>
> What are the exact conditions when the change is possible?
>
> I guess something like the value is only used for accessing its fields.
> and is not passed to any other function?
I expect the entire call tree needs to be known
and inspected for modification of fields.
next prev parent reply other threads:[~2014-09-26 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 20:14 [PATCH v3 net-next 0/3] tcp: better TCP_SKB_CB layout Eric Dumazet
2014-09-25 20:14 ` [PATCH v3 net-next 1/3] ipv4: rename ip_options_echo to __ip_options_echo() Eric Dumazet
2014-09-25 20:30 ` Joe Perches
2014-09-25 20:38 ` Eric Dumazet
2014-09-25 20:49 ` Joe Perches
2014-09-26 5:29 ` Julia Lawall
2014-09-26 8:08 ` Joe Perches [this message]
2014-09-26 6:21 ` Julia Lawall
2014-09-25 20:14 ` [PATCH v3 net-next 2/3] ipv6: add a struct inet6_skb_parm param to ipv6_opt_accepted() Eric Dumazet
2014-09-25 20:14 ` [PATCH v3 net-next 3/3] tcp: better TCP_SKB_CB layout to reduce cache line misses Eric Dumazet
2014-09-27 16:46 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411718885.19443.2.camel@joe-AO725 \
--to=joe@perches.com \
--cc=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox