[net-next] i40e: Fix dependencies in the i40e driver on configfs

[net-next] i40e: Fix dependencies in the i40e driver on configfs

[Jeff Kirsher]

From: Greg Rose <gregory.v.rose@intel.com>

Module dependencies are broken in the case where CONFIG_I40E=y and
CONFIG_CONFIGFS_FS=m.  This fixes the broken dependency.

Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/Kconfig | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
index f4ff465..7216a53 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -303,6 +303,15 @@ config I40E_FCOE
 
 	  If unsure, say N.
 
+config I40E_CONFIGFS_FS
+	bool "Config File System Support (configfs)"
+	default n
+	depends on I40E && CONFIGFS_FS && !(I40E=y && CONFIGFS_FS=m)
+	---help---
+	  Provides support for the configfs file system for additional
+	  driver configuration.  Say Y here if you want to use the
+	  configuration file system in the driver.
+
 config I40EVF
 	tristate "Intel(R) XL710 X710 Virtual Function Ethernet support"
 	depends on PCI_MSI
-- 
1.9.3

Re: [net-next] i40e: Fix dependencies in the i40e driver on configfs

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

On Tue, 2015-03-03 at 12:38 -0800, Jeff Kirsher wrote:
> From: Greg Rose <gregory.v.rose@intel.com>
> 
> Module dependencies are broken in the case where CONFIG_I40E=y and
> CONFIG_CONFIGFS_FS=m.  This fixes the broken dependency.
> 
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>  drivers/net/ethernet/intel/Kconfig | 9 +++++++++
>  1 file changed, 9 insertions(+)

This is to fix the current compile issues, I will continue to work with
the i40e development team to address Dave's concerns expressed earlier
in using configfs.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [net-next] i40e: Fix dependencies in the i40e driver on configfs

[David Miller]

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue,  3 Mar 2015 12:38:55 -0800

> From: Greg Rose <gregory.v.rose@intel.com>
> 
> Module dependencies are broken in the case where CONFIG_I40E=y and
> CONFIG_CONFIGFS_FS=m.  This fixes the broken dependency.
> 
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

This doesn't fix anything, nothing tests I40E_CONFIGFS_FS:

[davem@abraco net-next]$ make -s -j8
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
kernel/Makefile:133: *** No X.509 certificates found ***
kernel/Makefile:133: *** No X.509 certificates found ***
drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192df1): undefined reference to `config_group_init'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192e25): undefined reference to `configfs_register_subsystem'
drivers/built-in.o: In function `i40e_configfs_exit':
(.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
make: *** [vmlinux] Error 1
[davem@abraco net-next]$ git am --signoff diff
Applying: i40e: Fix dependencies in the i40e driver on configfs
[davem@abraco net-next]$ make oldconfig
scripts/kconfig/conf --oldconfig Kconfig
#
# configuration written to .config
#
[davem@abraco net-next]$ make -s -j8
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
kernel/Makefile:133: *** No X.509 certificates found ***
kernel/Makefile:133: *** No X.509 certificates found ***
drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192df1): undefined reference to `config_group_init'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x192e25): undefined reference to `configfs_register_subsystem'
drivers/built-in.o: In function `i40e_configfs_exit':
(.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
make: *** [vmlinux] Error 1
[davem@abraco net-next]$ 

Re: [net-next] i40e: Fix dependencies in the i40e driver on configfs

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 3103 bytes --]

On Tue, 2015-03-03 at 15:45 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Tue,  3 Mar 2015 12:38:55 -0800
> 
> > From: Greg Rose <gregory.v.rose@intel.com>
> > 
> > Module dependencies are broken in the case where CONFIG_I40E=y and
> > CONFIG_CONFIGFS_FS=m.  This fixes the broken dependency.
> > 
> > Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> 
> This doesn't fix anything, nothing tests I40E_CONFIGFS_FS:
> 
> [davem@abraco net-next]$ make -s -j8
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> kernel/Makefile:133: *** No X.509 certificates found ***
> kernel/Makefile:133: *** No X.509 certificates found ***
> drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192df1): undefined reference to `config_group_init'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192e25): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `i40e_configfs_exit':
> (.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
> make: *** [vmlinux] Error 1
> [davem@abraco net-next]$ git am --signoff diff
> Applying: i40e: Fix dependencies in the i40e driver on configfs
> [davem@abraco net-next]$ make oldconfig
> scripts/kconfig/conf --oldconfig Kconfig
> #
> # configuration written to .config
> #
> [davem@abraco net-next]$ make -s -j8
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> scripts/Makefile.kasan:16: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler
> kernel/Makefile:133: *** No X.509 certificates found ***
> kernel/Makefile:133: *** No X.509 certificates found ***
> drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> i40e_configfs.c:(.text+0x192db7): undefined reference to `config_item_init_type_name'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192df1): undefined reference to `config_group_init'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x192e25): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `i40e_configfs_exit':
> (.text+0x192e7a): undefined reference to `configfs_unregister_subsystem'
> make: *** [vmlinux] Error 1
> [davem@abraco net-next]$ 

Sorry it appears there were two issues that we needed to resolve.  The
first was the issue found with a randonconfig build where if the i40e
was compiled into the kernel and configfs was module, which this was
trying to correct.

The checks in the driver need to be changed from CONFIG_CONFIGFS_FS to
checking for CONFIG_I40E_CONFIGFS_FS, now that there is a Kconfig
option.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]