From: Jarno Rajahalme <jarno@ovn.org>
To: netfilter-devel@vger.kernel.org
Cc: netdev@vger.kernel.org, dev@openvswitch.org, jarno@ovn.org
Subject: [PATCH nf-next v9 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.
Date: Wed, 9 Mar 2016 15:10:17 -0800 [thread overview]
Message-ID: <1457565024-27300-1-git-send-email-jarno@ovn.org> (raw)
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does
not make sense. This allows the definition of IP_CT_NUMBER to be
simplified as well.
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
---
include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +++++++++---
net/openvswitch/conntrack.c | 2 --
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/netfilter/nf_conntrack_common.h b/include/uapi/linux/netfilter/nf_conntrack_common.h
index 319f471..6d074d1 100644
--- a/include/uapi/linux/netfilter/nf_conntrack_common.h
+++ b/include/uapi/linux/netfilter/nf_conntrack_common.h
@@ -20,9 +20,15 @@ enum ip_conntrack_info {
IP_CT_ESTABLISHED_REPLY = IP_CT_ESTABLISHED + IP_CT_IS_REPLY,
IP_CT_RELATED_REPLY = IP_CT_RELATED + IP_CT_IS_REPLY,
- IP_CT_NEW_REPLY = IP_CT_NEW + IP_CT_IS_REPLY,
- /* Number of distinct IP_CT types (no NEW in reply dirn). */
- IP_CT_NUMBER = IP_CT_IS_REPLY * 2 - 1
+ /* No NEW in reply direction. */
+
+ /* Number of distinct IP_CT types. */
+ IP_CT_NUMBER,
+
+ /* only for userspace compatibility */
+#ifndef __KERNEL__
+ IP_CT_NEW_REPLY = IP_CT_NUMBER,
+#endif
};
#define NF_CT_STATE_INVALID_BIT (1 << 0)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index ee6ff8f..3045290 100644
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -75,7 +75,6 @@ static u8 ovs_ct_get_state(enum ip_conntrack_info ctinfo)
switch (ctinfo) {
case IP_CT_ESTABLISHED_REPLY:
case IP_CT_RELATED_REPLY:
- case IP_CT_NEW_REPLY:
ct_state |= OVS_CS_F_REPLY_DIR;
break;
default:
@@ -92,7 +91,6 @@ static u8 ovs_ct_get_state(enum ip_conntrack_info ctinfo)
ct_state |= OVS_CS_F_RELATED;
break;
case IP_CT_NEW:
- case IP_CT_NEW_REPLY:
ct_state |= OVS_CS_F_NEW;
break;
default:
--
2.1.4
next reply other threads:[~2016-03-09 23:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 23:10 Jarno Rajahalme [this message]
[not found] ` <1457565024-27300-1-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-09 23:10 ` [PATCH nf-next v9 2/8] netfilter: Allow calling into nat helper without skb_dst Jarno Rajahalme
2016-03-09 23:10 ` [PATCH nf-next v9 4/8] openvswitch: Update the CT state key only after nf_conntrack_in() Jarno Rajahalme
[not found] ` <1457565024-27300-4-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 2:12 ` Joe Stringer
2016-03-09 23:10 ` [PATCH nf-next v9 3/8] openvswitch: Add commentary to conntrack.c Jarno Rajahalme
2016-03-09 23:10 ` [PATCH nf-next v9 5/8] openvswitch: Find existing conntrack entry after upcall Jarno Rajahalme
[not found] ` <1457565024-27300-5-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 2:29 ` Joe Stringer
2016-03-09 23:10 ` [PATCH nf-next v9 6/8] openvswitch: Handle NF_REPEAT in conntrack action Jarno Rajahalme
2016-03-09 23:10 ` [PATCH nf-next v9 7/8] openvswitch: Delay conntrack helper call for new connections Jarno Rajahalme
[not found] ` <1457565024-27300-7-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 2:37 ` Joe Stringer
2016-03-09 23:10 ` [PATCH nf-next v9 8/8] openvswitch: Interface with NAT Jarno Rajahalme
[not found] ` <1457565024-27300-8-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 3:47 ` Joe Stringer
[not found] ` <CAPWQB7GkhrfZaaT-LkTP7Esfj4tzU=Fgto2ZaSq4YkurhOf8bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-10 12:00 ` Thomas Graf
[not found] ` <20160310120021.GA26693-4EA/1caXOu0mYvmMESoHnA@public.gmane.org>
2016-03-10 18:45 ` Jarno Rajahalme
2016-03-10 18:55 ` Jarno Rajahalme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457565024-27300-1-git-send-email-jarno@ovn.org \
--to=jarno@ovn.org \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox