From: Jarno Rajahalme <jarno@ovn.org>
To: netfilter-devel@vger.kernel.org
Cc: netdev@vger.kernel.org, dev@openvswitch.org, jarno@ovn.org
Subject: [PATCH nf-next v9 6/8] openvswitch: Handle NF_REPEAT in conntrack action.
Date: Wed, 9 Mar 2016 15:10:22 -0800 [thread overview]
Message-ID: <1457565024-27300-6-git-send-email-jarno@ovn.org> (raw)
In-Reply-To: <1457565024-27300-1-git-send-email-jarno@ovn.org>
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This
avoids dropping a SYN packet re-opening an existing TCP connection.
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Joe Stringer <joe@ovn.org>
---
net/openvswitch/conntrack.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index b838536..92613de 100644
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -485,6 +485,7 @@ static int __ovs_ct_lookup(struct net *net, struct sw_flow_key *key,
*/
if (!skb_nfct_cached(net, key, info, skb)) {
struct nf_conn *tmpl = info->ct;
+ int err;
/* Associate skb with specified zone. */
if (tmpl) {
@@ -495,8 +496,13 @@ static int __ovs_ct_lookup(struct net *net, struct sw_flow_key *key,
skb->nfctinfo = IP_CT_NEW;
}
- if (nf_conntrack_in(net, info->family, NF_INET_PRE_ROUTING,
- skb) != NF_ACCEPT)
+ /* Repeat if requested, see nf_iterate(). */
+ do {
+ err = nf_conntrack_in(net, info->family,
+ NF_INET_PRE_ROUTING, skb);
+ } while (err == NF_REPEAT);
+
+ if (err != NF_ACCEPT)
return -ENOENT;
ovs_ct_update_key(skb, info, key, true);
--
2.1.4
next prev parent reply other threads:[~2016-03-09 23:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 23:10 [PATCH nf-next v9 1/8] netfilter: Remove IP_CT_NEW_REPLY definition Jarno Rajahalme
[not found] ` <1457565024-27300-1-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-09 23:10 ` [PATCH nf-next v9 2/8] netfilter: Allow calling into nat helper without skb_dst Jarno Rajahalme
2016-03-09 23:10 ` [PATCH nf-next v9 4/8] openvswitch: Update the CT state key only after nf_conntrack_in() Jarno Rajahalme
[not found] ` <1457565024-27300-4-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 2:12 ` Joe Stringer
2016-03-09 23:10 ` [PATCH nf-next v9 3/8] openvswitch: Add commentary to conntrack.c Jarno Rajahalme
2016-03-09 23:10 ` [PATCH nf-next v9 5/8] openvswitch: Find existing conntrack entry after upcall Jarno Rajahalme
[not found] ` <1457565024-27300-5-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 2:29 ` Joe Stringer
2016-03-09 23:10 ` Jarno Rajahalme [this message]
2016-03-09 23:10 ` [PATCH nf-next v9 7/8] openvswitch: Delay conntrack helper call for new connections Jarno Rajahalme
[not found] ` <1457565024-27300-7-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 2:37 ` Joe Stringer
2016-03-09 23:10 ` [PATCH nf-next v9 8/8] openvswitch: Interface with NAT Jarno Rajahalme
[not found] ` <1457565024-27300-8-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2016-03-10 3:47 ` Joe Stringer
[not found] ` <CAPWQB7GkhrfZaaT-LkTP7Esfj4tzU=Fgto2ZaSq4YkurhOf8bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-10 12:00 ` Thomas Graf
[not found] ` <20160310120021.GA26693-4EA/1caXOu0mYvmMESoHnA@public.gmane.org>
2016-03-10 18:45 ` Jarno Rajahalme
2016-03-10 18:55 ` Jarno Rajahalme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457565024-27300-6-git-send-email-jarno@ovn.org \
--to=jarno@ovn.org \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox