[PATCH net-next] veth: fix setting peer gso values

[PATCH net-next] veth: fix setting peer gso values

[Solio Sarabia]

GSO values are not correctly set for peer and dev. When creating
the veth link, GSO attributes are set for peer device, propagate
these values from peer to dev.

Signed-off-by: Solio Sarabia <solio.sarabia@intel.com>
---
 drivers/net/veth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index a69ad39..d936c8a 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -410,8 +410,8 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
 	if (ifmp && (dev->ifindex != 0))
 		peer->ifindex = ifmp->ifi_index;
 
-	peer->gso_max_size = dev->gso_max_size;
-	peer->gso_max_segs = dev->gso_max_segs;
+	dev->gso_max_size = peer->gso_max_size;
+	dev->gso_max_segs = peer->gso_max_segs;
 
 	err = register_netdevice(peer);
 	put_net(net);
-- 
2.7.4

Re: [PATCH net-next] veth: fix setting peer gso values

[Solio Sarabia]

On Sat, Dec 09, 2017 at 11:11:33AM -0800, Solio Sarabia wrote:
> GSO values are not correctly set for peer and dev. When creating
> the veth link, GSO attributes are set for peer device, propagate
> these values from peer to dev.
> 
> Signed-off-by: Solio Sarabia <solio.sarabia@intel.com>
> ---
>  drivers/net/veth.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index a69ad39..d936c8a 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -410,8 +410,8 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
>  	if (ifmp && (dev->ifindex != 0))
>  		peer->ifindex = ifmp->ifi_index;
>  
> -	peer->gso_max_size = dev->gso_max_size;
> -	peer->gso_max_segs = dev->gso_max_segs;
> +	dev->gso_max_size = peer->gso_max_size;
> +	dev->gso_max_segs = peer->gso_max_segs;

Seems this patch won't be necessary after all. Parameter order in
iproute2 util will be changed to set GSO on first dev device (not
on the peer), making current code right: cloning from dev to peer.

>  
>  	err = register_netdevice(peer);
>  	put_net(net);
> -- 
> 2.7.4
>