From: Yafang Shao <laoar.shao@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state
Date: Fri, 22 Dec 2017 23:37:13 +0800 [thread overview]
Message-ID: <1513957033-24100-1-git-send-email-laoar.shao@gmail.com> (raw)
There's a space character missed in the printk messages.
This error should be prevented with checkscript.pl, but it couldn't caught
by running with "checkscript.pl -f xxxx.patch", that's what I had run
before.
What a carelessness.
Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint with
inet_sock_set_state tracepoint")
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
include/trace/events/sock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h
index 3b9094a..598399da 100644
--- a/include/trace/events/sock.h
+++ b/include/trace/events/sock.h
@@ -160,7 +160,7 @@
}
),
- TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4"
+ TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 "
"saddrv6=%pI6c daddrv6=%pI6c oldstate=%s newstate=%s",
show_inet_protocol_name(__entry->protocol),
__entry->sport, __entry->dport,
next reply other threads:[~2017-12-22 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 15:37 Yafang Shao [this message]
2017-12-22 17:04 ` [PATCH net-next] net/trace: fix printk format in inet_sock_set_state Sergei Shtylyov
2017-12-23 1:10 ` Yafang Shao
2017-12-23 1:19 ` Yafang Shao
2017-12-23 9:42 ` Sergei Shtylyov
2017-12-23 13:08 ` Yafang Shao
-- strict thread matches above, loose matches on Subject: below --
2017-12-23 1:14 Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513957033-24100-1-git-send-email-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox