From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state
Date: Sat, 23 Dec 2017 12:42:03 +0300 [thread overview]
Message-ID: <b81b77f8-77fb-4b87-5ddd-4d383abacece@cogentembedded.com> (raw)
In-Reply-To: <CALOAHbB10mLdV_0p7vWv8w4snG2JEnUSkYUXBjC-BvP+b5AVDw@mail.gmail.com>
On 12/23/2017 4:10 AM, Yafang Shao wrote:
>>> There's a space character missed in the printk messages.
>>> This error should be prevented with checkscript.pl, but it couldn't caught
> It is checkpatch.pl.
Yes, that too. But I actually meant you missed "be" between "couldn't" and
"caught"...
>>> by running with "checkscript.pl -f xxxx.patch", that's what I had run
>>> before.
>>> What a carelessness.
>> You generally don't need to break up the messages violating 80-column
>> limit, and checkpatch.pl should be aware of this...
> Oh. That's right.
> It can be aware of that.
It is aware --- I'm just not sure it recognizes TP_printk() -- like it
does recognize printk() fo that purpose.
> I just want to make the code easy to read and limit the textwidth to
> 80 character.
Contrariwise, that's what you shouldn't do. Would simplify searching for
the messages in the kernel source.
> If the message takes two lines as bellow,
> printk("xxx "
> ^ space character.
> "yyy");
> The checkpatch.pl could also be aware of that if the first line is
> not end with space character, but it couldn't be aware of that if run
> with "checkpatch.pl -f xxxx.patch".
Option -f tells checkpatch.pl that it should check a source file, not a
patch. I don't know why you use that with the patches...
>>> Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint
>>> with
>>> inet_sock_set_state tracepoint")
>>> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2017-12-23 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 15:37 [PATCH net-next] net/trace: fix printk format in inet_sock_set_state Yafang Shao
2017-12-22 17:04 ` Sergei Shtylyov
2017-12-23 1:10 ` Yafang Shao
2017-12-23 1:19 ` Yafang Shao
2017-12-23 9:42 ` Sergei Shtylyov [this message]
2017-12-23 13:08 ` Yafang Shao
-- strict thread matches above, loose matches on Subject: below --
2017-12-23 1:14 Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b81b77f8-77fb-4b87-5ddd-4d383abacece@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox