[PATCH] net: atm: fix skb leak in sigd_send() default branch

[PATCH] net: atm: fix skb leak in sigd_send() default branch

[albin_yang]

From: Wei Yang <albinwyang@tencent.com>

The default branch in sigd_send() calls sock_put() and returns -EINVAL
without freeing the skb, while all other exit paths do so. Add the
missing dev_kfree_skb() before sock_put() to fix the leak.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Wei Yang <albinwyang@tencent.com>
---
 net/atm/signaling.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/atm/signaling.c b/net/atm/signaling.c
index ae88a5d2f29b..0000000000000 100644
--- a/net/atm/signaling.c
+++ b/net/atm/signaling.c
@@ -179,6 +179,7 @@ static int sigd_send(struct atm_vcc *vcc, struct sk_buff *skb)
 	default:
 		pr_alert("bad message type %d\n", (int)msg->type);
+		dev_kfree_skb(skb);
 		/* Paired with find_get_vcc(msg->vcc) above */
 		sock_put(sk);
 		return -EINVAL;
 	}

Re: [PATCH] net: atm: fix skb leak in sigd_send() default branch

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat,  9 May 2026 20:23:58 +0800 you wrote:
> From: Wei Yang <albinwyang@tencent.com>
> 
> The default branch in sigd_send() calls sock_put() and returns -EINVAL
> without freeing the skb, while all other exit paths do so. Add the
> missing dev_kfree_skb() before sock_put() to fix the leak.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Wei Yang <albinwyang@tencent.com>
> 
> [...]

Here is the summary with links:
  - net: atm: fix skb leak in sigd_send() default branch
    https://git.kernel.org/netdev/net/c/f9e2342046ef

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html