[PATCH net] selftests: rds: config: disable modules

[PATCH net] selftests: rds: config: disable modules

[Matthieu Baerts (NGI0)]

The run.sh script explicitly checks that CONFIG_MODULES is disabled.

By default, this config option is enabled. Explicitly disable it to be
able to run the RDS tests.

Note that writing '# CONFIG_(...) is not set' is usually recommended to
disable an option in the .config, but it looks like selftests usually
set 'CONFIG_(...)=n', which looks clearer.

Fixes: 0f5d68004780 ("selftests: rds: add tools/testing/selftests/net/rds/config")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/rds/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/rds/config b/tools/testing/selftests/net/rds/config
index 97db7ecb892a..3d62d0c750a8 100644
--- a/tools/testing/selftests/net/rds/config
+++ b/tools/testing/selftests/net/rds/config
@@ -1,3 +1,4 @@
+CONFIG_MODULES=n
 CONFIG_NET_NS=y
 CONFIG_NET_SCH_NETEM=y
 CONFIG_RDS=y

---
base-commit: 90fc1a393736063b2b4077115e215a2e2eebb797
change-id: 20260520-net-rds-config-modules-cada926dc526

Best regards,
--  
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH net] selftests: rds: config: disable modules

[Allison Henderson]

On Wed, 2026-05-20 at 11:34 +1000, Matthieu Baerts (NGI0) wrote:
> The run.sh script explicitly checks that CONFIG_MODULES is disabled.
> 
> By default, this config option is enabled. Explicitly disable it to be
> able to run the RDS tests.
> 
> Note that writing '# CONFIG_(...) is not set' is usually recommended to
> disable an option in the .config, but it looks like selftests usually
> set 'CONFIG_(...)=n', which looks clearer.
> 
> Fixes: 0f5d68004780 ("selftests: rds: add tools/testing/selftests/net/rds/config")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
>  tools/testing/selftests/net/rds/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/rds/config b/tools/testing/selftests/net/rds/config
> index 97db7ecb892a..3d62d0c750a8 100644
> --- a/tools/testing/selftests/net/rds/config
> +++ b/tools/testing/selftests/net/rds/config
> @@ -1,3 +1,4 @@
> +CONFIG_MODULES=n
>  CONFIG_NET_NS=y
>  CONFIG_NET_SCH_NETEM=y
>  CONFIG_RDS=y
> 
> ---
> base-commit: 90fc1a393736063b2b4077115e215a2e2eebb797
> change-id: 20260520-net-rds-config-modules-cada926dc526
> 
> Best regards,
> --  
> Matthieu Baerts (NGI0) <matttbe@kernel.org>

Hi Matthieu,

The fix looks fine to me.  Thanks for catching this.

Reviewed-by: Allison Henderson <achender@kernel.org>
Allison

> 

Re: [PATCH net] selftests: rds: config: disable modules

[Matthieu Baerts]

Hi Allison,

On 20/05/2026 14:22, Allison Henderson wrote:
> On Wed, 2026-05-20 at 11:34 +1000, Matthieu Baerts (NGI0) wrote:
>> The run.sh script explicitly checks that CONFIG_MODULES is disabled.
>>
>> By default, this config option is enabled. Explicitly disable it to be
>> able to run the RDS tests.
>>
>> Note that writing '# CONFIG_(...) is not set' is usually recommended to
>> disable an option in the .config, but it looks like selftests usually
>> set 'CONFIG_(...)=n', which looks clearer.

(...)
> The fix looks fine to me.  Thanks for catching this.
Thank you for the review. Note that NIPA is now validating these tests:

  https://netdev.bots.linux.dev/contest.html?test=run-sh
  https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=run-sh

Note that it might be good to rename the script name, "run.sh" is a bit
too generic :)

Cheers,
Matt

Re: [PATCH net] selftests: rds: config: disable modules

[Jakub Kicinski]

On Wed, 20 May 2026 11:34:43 +1000 Matthieu Baerts (NGI0) wrote:
> The run.sh script explicitly checks that CONFIG_MODULES is disabled.
> 
> By default, this config option is enabled. Explicitly disable it to be
> able to run the RDS tests.
> 
> Note that writing '# CONFIG_(...) is not set' is usually recommended to
> disable an option in the .config, but it looks like selftests usually
> set 'CONFIG_(...)=n', which looks clearer.
> 
> Fixes: 0f5d68004780 ("selftests: rds: add tools/testing/selftests/net/rds/config")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
>  tools/testing/selftests/net/rds/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/rds/config b/tools/testing/selftests/net/rds/config
> index 97db7ecb892a..3d62d0c750a8 100644
> --- a/tools/testing/selftests/net/rds/config
> +++ b/tools/testing/selftests/net/rds/config
> @@ -1,3 +1,4 @@
> +CONFIG_MODULES=n
>  CONFIG_NET_NS=y
>  CONFIG_NET_SCH_NETEM=y
>  CONFIG_RDS=y

Hm, okay, if it works it works, but IIUC disabling modules turns all =m
from the default config into =n (not =y as one would naively hope?) so
this may come back to bite us. Unless there's a strong reason to not use
modules it may be good to follow up in net-next and life this
requirement.

Re: [PATCH net] selftests: rds: config: disable modules

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 20 May 2026 11:34:43 +1000 you wrote:
> The run.sh script explicitly checks that CONFIG_MODULES is disabled.
> 
> By default, this config option is enabled. Explicitly disable it to be
> able to run the RDS tests.
> 
> Note that writing '# CONFIG_(...) is not set' is usually recommended to
> disable an option in the .config, but it looks like selftests usually
> set 'CONFIG_(...)=n', which looks clearer.
> 
> [...]

Here is the summary with links:
  - [net] selftests: rds: config: disable modules
    https://git.kernel.org/netdev/net/c/92cc6708f4a2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html