Re: [PATCH net-next 04/10] ice: increase OICR interrupt moderation rate to 20K interrupts/sec

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] This patch removes the only user of ICE_ITR_8K (the OICR ITR
  write in ice_req_irq_msix_misc(),…

--

ice: increase OICR interrupt moderation rate to 20K interrupts/sec

This commit raises the OICR interrupt throttle rate in
ice_req_irq_msix_misc() from 8K interrupts per second to 20K.
The goal is lower latency for VF mailbox messages and Tx timestamp
handling.

> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 707c7431b91a6..73f69d453542b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -3428,7 +3428,7 @@ static int ice_req_irq_msix_misc(struct ice_pf *pf)
>  		     ((pf->ll_ts_irq.index + pf_intr_start_offset) &
>  		      PFINT_SB_CTL_MSIX_INDX_M) | PFINT_SB_CTL_CAUSE_ENA_M);
>  	wr32(hw, GLINT_ITR(ICE_RX_ITR, pf->oicr_irq.index),
> -	     ITR_REG_ALIGN(ICE_ITR_8K) >> ICE_ITR_GRAN_S);
> +	     ITR_REG_ALIGN(ICE_ITR_20K) >> ICE_ITR_GRAN_S);

[Severity: Low]
This isn't a bug, but this change removes the last user of ICE_ITR_8K.
After this patch the only remaining match for it under
drivers/net/ethernet/intel/ is the definition in
drivers/net/ethernet/intel/ice/ice_txrx.h:

#define ICE_ITR_8K	124
#define ICE_ITR_20K	50

Should the now unused ICE_ITR_8K define be removed, either in this patch
or in a follow-up?

>  
>  	ice_flush(hw);
>  	ice_irq_dynamic_ena(hw, NULL, NULL);

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260929224153.1455466-1-anthony.l.nguyen%40intel.com