Re: [PATCH net-next 08/10] ice: simplify ice_pf_state_is_nominal()

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message for "ice: simplify ice_pf_state_is_nominal()"
  names the wrong helper.

--

ice: simplify ice_pf_state_is_nominal()

This commit changes ice_pf_state_is_nominal() so it no longer builds a
temporary mask on the stack and calls bitmap_intersects(). It now calls
bitmap_empty() on the first ICE_STATE_NOMINAL_CHECK_BITS of pf->state.

> The function creates a temporary mask on stack just to check that
> first ICE_STATE_NOMINAL_CHECK_BITS is empty. Simplify it by using
> the ice_pf_state_is_nominal().

[Severity: Low]
This isn't a bug, but should this say bitmap_empty() instead of
ice_pf_state_is_nominal()? As written, the sentence names the function
being changed.

The helper the patch adds in ice_pf_state_is_nominal() is:

	return bitmap_empty(pf->state, ICE_STATE_NOMINAL_CHECK_BITS);

Would "Simplify it by using bitmap_empty()" be the intended wording?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260929224153.1455466-1-anthony.l.nguyen%40intel.com