Netdev List
 help / color / mirror / Atom feed
* [PATCH net-next] net: zero hw address entries on allocation
@ 2026-11-22  0:26 Yuyang Huang
  2026-11-22  0:32 ` netdev-bot+sinfo
  0 siblings, 1 reply; 3+ messages in thread
From: Yuyang Huang @ 2026-11-22  0:26 UTC (permalink / raw)
  To: Yuyang Huang
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Nicolas Dichtel,
	Paolo Abeni, Simon Horman, Stanislav Fomichev, netdev

__hw_addr_create() allocates struct netdev_hw_addr with kmalloc() and
copies only addr_len bytes into ha->addr[MAX_ADDR_LEN], leaving the
rest uninitialized.

If dev->addr_len later grows while entries remain (e.g., adding a
multicast address to a down TAP device with SIOCADDMULTI and then
switching it to ARPHRD_TUNNEL6 via TUNSETLINK), readers using
dev->addr_len such as /proc/net/dev_mcast and AF_PACKET
RTM_GETMULTICAST expose the uninitialized trailing slab bytes, and
__hw_addr_add_ex() reads them in memcmp().

Switch __hw_addr_create() to kzalloc() so the unused tail of ha->addr
is always zero.

Link: https://lore.kernel.org/netdev/179012275175.2160803.16091441325063775173@kernel.org/
Signed-off-by: Yuyang Huang <yuyanghuang@google.com>
---
 net/core/dev_addr_lists.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c
index b6f25e487984..ff0815d8f6a8 100644
--- a/net/core/dev_addr_lists.c
+++ b/net/core/dev_addr_lists.c
@@ -100,7 +100,7 @@ __hw_addr_create(const unsigned char *addr, int addr_len,
 	alloc_size = sizeof(*ha);
 	if (alloc_size < L1_CACHE_BYTES)
 		alloc_size = L1_CACHE_BYTES;
-	ha = kmalloc(alloc_size, GFP_ATOMIC);
+	ha = kzalloc(alloc_size, GFP_ATOMIC);
 	if (!ha)
 		return NULL;
 	memcpy(ha->addr, addr, addr_len);
-- 
2.56.1.750.gf70dc682cf-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-22  0:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22  0:26 [PATCH net-next] net: zero hw address entries on allocation Yuyang Huang
2026-11-22  0:32 ` netdev-bot+sinfo
2026-11-22  0:38   ` Yuyang Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox