Netdev List
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: <ganeshgr@chelsio.com>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] cxgb4: remove set but not used variable 'spd'
Date: Mon, 13 Aug 2018 14:50:44 +0800	[thread overview]
Message-ID: <1cd1bf32-e4a6-c0ae-c5c0-f991968b4ba0@huawei.com> (raw)
In-Reply-To: <20180813064851.912-1-yuehaibing@huawei.com>

Sorry, this should be for net-next

On 2018/8/13 14:48, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'print_port_info':
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5147:14: warning:
>  variable 'spd' set but not used [-Wunused-but-set-variable]
> 
> variable 'spd' is set but not used since
> commit 547fd27241a8 ("cxgb4: Warn if device doesn't have enough PCI bandwidth")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> index 69590cf..961e3087 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> @@ -5144,17 +5144,9 @@ static void print_port_info(const struct net_device *dev)
>  {
>  	char buf[80];
>  	char *bufp = buf;
> -	const char *spd = "";
>  	const struct port_info *pi = netdev_priv(dev);
>  	const struct adapter *adap = pi->adapter;
>  
> -	if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_2_5GB)
> -		spd = " 2.5 GT/s";
> -	else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_5_0GB)
> -		spd = " 5 GT/s";
> -	else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_8_0GB)
> -		spd = " 8 GT/s";
> -
>  	if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_100M)
>  		bufp += sprintf(bufp, "100M/");
>  	if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_1G)
> 

  reply	other threads:[~2018-08-13  6:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13  6:48 [PATCH] cxgb4: remove set but not used variable 'spd' YueHaibing
2018-08-13  6:50 ` YueHaibing [this message]
2018-08-13 16:48 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cd1bf32-e4a6-c0ae-c5c0-f991968b4ba0@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=davem@davemloft.net \
    --cc=ganeshgr@chelsio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox