* [PATCH] cxgb4: remove set but not used variable 'spd'
@ 2018-08-13 6:48 YueHaibing
2018-08-13 6:50 ` YueHaibing
2018-08-13 16:48 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-08-13 6:48 UTC (permalink / raw)
To: ganeshgr, davem; +Cc: linux-kernel, netdev, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'print_port_info':
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5147:14: warning:
variable 'spd' set but not used [-Wunused-but-set-variable]
variable 'spd' is set but not used since
commit 547fd27241a8 ("cxgb4: Warn if device doesn't have enough PCI bandwidth")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 69590cf..961e3087 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -5144,17 +5144,9 @@ static void print_port_info(const struct net_device *dev)
{
char buf[80];
char *bufp = buf;
- const char *spd = "";
const struct port_info *pi = netdev_priv(dev);
const struct adapter *adap = pi->adapter;
- if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_2_5GB)
- spd = " 2.5 GT/s";
- else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_5_0GB)
- spd = " 5 GT/s";
- else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_8_0GB)
- spd = " 8 GT/s";
-
if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_100M)
bufp += sprintf(bufp, "100M/");
if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_1G)
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cxgb4: remove set but not used variable 'spd'
2018-08-13 6:48 [PATCH] cxgb4: remove set but not used variable 'spd' YueHaibing
@ 2018-08-13 6:50 ` YueHaibing
2018-08-13 16:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-08-13 6:50 UTC (permalink / raw)
To: ganeshgr, davem; +Cc: linux-kernel, netdev
Sorry, this should be for net-next
On 2018/8/13 14:48, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'print_port_info':
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5147:14: warning:
> variable 'spd' set but not used [-Wunused-but-set-variable]
>
> variable 'spd' is set but not used since
> commit 547fd27241a8 ("cxgb4: Warn if device doesn't have enough PCI bandwidth")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> index 69590cf..961e3087 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> @@ -5144,17 +5144,9 @@ static void print_port_info(const struct net_device *dev)
> {
> char buf[80];
> char *bufp = buf;
> - const char *spd = "";
> const struct port_info *pi = netdev_priv(dev);
> const struct adapter *adap = pi->adapter;
>
> - if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_2_5GB)
> - spd = " 2.5 GT/s";
> - else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_5_0GB)
> - spd = " 5 GT/s";
> - else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_8_0GB)
> - spd = " 8 GT/s";
> -
> if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_100M)
> bufp += sprintf(bufp, "100M/");
> if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_1G)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cxgb4: remove set but not used variable 'spd'
2018-08-13 6:48 [PATCH] cxgb4: remove set but not used variable 'spd' YueHaibing
2018-08-13 6:50 ` YueHaibing
@ 2018-08-13 16:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-08-13 16:48 UTC (permalink / raw)
To: yuehaibing; +Cc: ganeshgr, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 13 Aug 2018 14:48:51 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'print_port_info':
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5147:14: warning:
> variable 'spd' set but not used [-Wunused-but-set-variable]
>
> variable 'spd' is set but not used since
> commit 547fd27241a8 ("cxgb4: Warn if device doesn't have enough PCI bandwidth")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-13 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-13 6:48 [PATCH] cxgb4: remove set but not used variable 'spd' YueHaibing
2018-08-13 6:50 ` YueHaibing
2018-08-13 16:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox