* net nasties in davem's tree
@ 2007-03-30 1:37 Andrew Morton
2007-03-30 2:03 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-03-30 1:37 UTC (permalink / raw)
To: netdev
drivers/net/3c523.c: In function 'elmc_send_packet':
drivers/net/3c523.c:1148: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
drivers/net/ni52.c: In function 'ni52_send_packet':
drivers/net/ni52.c:1185: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: net nasties in davem's tree
2007-03-30 1:37 net nasties in davem's tree Andrew Morton
@ 2007-03-30 2:03 ` David Miller
2007-03-30 2:06 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2007-03-30 2:03 UTC (permalink / raw)
To: akpm; +Cc: netdev
From: Andrew Morton <akpm@linux-foundation.org>
Date: Thu, 29 Mar 2007 18:37:30 -0700
> drivers/net/3c523.c: In function 'elmc_send_packet':
> drivers/net/3c523.c:1148: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
> drivers/net/ni52.c: In function 'ni52_send_packet':
> drivers/net/ni52.c:1185: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
We should probably mark the "to" argument to skb_copy_from_linear_data()
as const, I'll take care of that.
Thanks for the report.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: net nasties in davem's tree
2007-03-30 2:03 ` David Miller
@ 2007-03-30 2:06 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-03-30 2:06 UTC (permalink / raw)
To: akpm; +Cc: netdev
From: David Miller <davem@davemloft.net>
Date: Thu, 29 Mar 2007 19:03:17 -0700 (PDT)
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Thu, 29 Mar 2007 18:37:30 -0700
>
> > drivers/net/3c523.c: In function 'elmc_send_packet':
> > drivers/net/3c523.c:1148: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
> > drivers/net/ni52.c: In function 'ni52_send_packet':
> > drivers/net/ni52.c:1185: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
>
> We should probably mark the "to" argument to skb_copy_from_linear_data()
> as const, I'll take care of that.
>
> Thanks for the report.
My bad, what's going on in the first case is the driver
has "volatile disease". I'll add back the (char *) cast
that was in the original memcpy().
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-30 2:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-30 1:37 net nasties in davem's tree Andrew Morton
2007-03-30 2:03 ` David Miller
2007-03-30 2:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox