From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [NET]: Get rid of NETIF_F_INTERNAL_STATS
Date: Wed, 11 Apr 2007 22:23:17 +1000 [thread overview]
Message-ID: <20070411122317.GA21159@gondor.apana.org.au> (raw)
In-Reply-To: <1176293751.14322.14.camel@localhost.localdomain>
On Wed, Apr 11, 2007 at 10:15:51PM +1000, Rusty Russell wrote:
>
> Actually, I did this precisely because I really didn't want to start
> exposing bogus stats in /proc/net/dev. An audit might clarify if this
> is an actual issue.
Fair enough. Still returning zeros when get_stats isn't available
would seem safe enough. I wasn't able to find any drivers which
didn't have get_stats.
> > This also fixes a potential crash in those get_stats callers that
> > don't check for a NULL return value (e.g., /proc/net/dev).
>
> Hmm, I thought it did that in my original patch?
Sorry, I was looking at the wrong tree.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-04-11 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 7:56 [NET]: Get rid of NETIF_F_INTERNAL_STATS Herbert Xu
2007-04-11 12:15 ` Rusty Russell
2007-04-11 12:23 ` Herbert Xu [this message]
2007-04-13 23:19 ` David Miller
2007-04-28 5:46 ` Rusty Russell
2007-04-28 5:52 ` Herbert Xu
2007-04-29 4:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070411122317.GA21159@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox