From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: rusty@rustcorp.com.au, netdev@vger.kernel.org, jgarzik@pobox.com,
buytenh@gnu.org
Subject: Re: [NET]: Get rid of NETIF_F_INTERNAL_STATS
Date: Sat, 28 Apr 2007 21:04:24 -0700 (PDT) [thread overview]
Message-ID: <20070428.210424.98555920.davem@davemloft.net> (raw)
In-Reply-To: <20070428055246.GA6172@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 28 Apr 2007 15:52:46 +1000
> > ==
> > Remove NETIF_F_INTERNAL_STATS: default to internal stats.
> >
> > Herbert Xu conviced me that a new flag was overkill; every driver
> > currently overrides get_stats, so we might as well make the internal
> > one the default. If someone did fail to set get_stats, they would now
> > get all 0 stats instead of "No statistics available".
> >
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Looks good to me.
Applied, thanks everyone.
prev parent reply other threads:[~2007-04-29 4:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 7:56 [NET]: Get rid of NETIF_F_INTERNAL_STATS Herbert Xu
2007-04-11 12:15 ` Rusty Russell
2007-04-11 12:23 ` Herbert Xu
2007-04-13 23:19 ` David Miller
2007-04-28 5:46 ` Rusty Russell
2007-04-28 5:52 ` Herbert Xu
2007-04-29 4:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428.210424.98555920.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@gnu.org \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox