Re: [NET]: Get rid of NETIF_F_INTERNAL_STATS

[Herbert Xu <herbert@gondor.apana.org.au>]

On Sat, Apr 28, 2007 at 03:46:01PM +1000, Rusty Russell wrote:
> 
> OK, I did a quick check, and the only one I could find was br_if.c which
> calls register_netdevice() and doesn't set get_stats.  I don't think
> that zeroes in this case matters.

Thanks for following up on this Rusty!

Actually I just had a look at br_if.c and it seems that it does set
get_stats through br_dev_setup to br_dev_get_stats.

> ==
> Remove NETIF_F_INTERNAL_STATS: default to internal stats.
> 
> Herbert Xu conviced me that a new flag was overkill; every driver
> currently overrides get_stats, so we might as well make the internal
> one the default.  If someone did fail to set get_stats, they would now
> get all 0 stats instead of "No statistics available".
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Looks good to me.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt