From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Robert Olsson <Robert.Olsson@data.slu.se>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Robert.Olsson@data.slu.se,
Auke Kok <sofar@foo-projects.org>
Subject: Re: net_rx_action/NAPI oops [PATCH]
Date: Tue, 27 Nov 2007 14:09:04 -0800 [thread overview]
Message-ID: <20071127140904.20c4cba8@freepuppy.rosehill> (raw)
In-Reply-To: <18252.26472.319078.165019@robur.slu.se>
On Tue, 27 Nov 2007 19:52:24 +0100
Robert Olsson <Robert.Olsson@data.slu.se> wrote:
>
> Hello!
>
> I've discovered a bug while testing the new multiQ NAPI code. In hi-load
> situations when we take down an interface we get a kernel panic. The
> oops is below.
>
> From what I see this happens when driver does napi_disable() and clears
> NAPI_STATE_SCHED. In net_rx_action there is a check for work == weight
> a sort indirect test but that's now not enough to cover the load situation.
> where we have NAPI_STATE_SCHED cleared by e1000_down in my case and still
> full quota. Latest git but I'll guess the is the same in all later kernels.
> There might be different solutions... one variant is below:
It is considered a driver bug in 2.6.24 to call netif_rx_complete (clear NAPI_STATE_SCHED)
and do a full quota. That bug already had to be fixed in other drivers,
look like e1000 has same problem.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-11-27 22:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 18:52 net_rx_action/NAPI oops [PATCH] Robert Olsson
2007-11-27 22:09 ` Stephen Hemminger [this message]
2007-11-27 22:34 ` Kok, Auke
2007-11-27 22:55 ` Stephen Hemminger
2007-11-28 0:24 ` Kok, Auke
2007-11-28 12:36 ` Robert Olsson
2007-11-28 16:38 ` Stephen Hemminger
2007-11-28 17:22 ` Robert Olsson
2007-11-30 16:56 ` Robert Olsson
2007-11-30 17:13 ` Kok, Auke
2007-11-28 12:27 ` Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127140904.20c4cba8@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sofar@foo-projects.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox