From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Robert Olsson <Robert.Olsson@data.slu.se>
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>,
Robert Olsson <Robert.Olsson@data.slu.se>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: net_rx_action/NAPI oops [PATCH]
Date: Wed, 28 Nov 2007 08:38:26 -0800 [thread overview]
Message-ID: <20071128083826.3a9400d1@freepuppy.rosehill> (raw)
In-Reply-To: <18253.24783.174884.502970@robur.slu.se>
Would this fix it?
--- a/drivers/net/e1000/e1000_main.c 2007-11-15 21:13:12.000000000 -0800
+++ b/drivers/net/e1000/e1000_main.c 2007-11-28 08:37:03.000000000 -0800
@@ -630,10 +630,10 @@ e1000_down(struct e1000_adapter *adapter
* reschedule our watchdog timer */
set_bit(__E1000_DOWN, &adapter->flags);
+ e1000_irq_disable(adapter);
#ifdef CONFIG_E1000_NAPI
- napi_disable(&adapter->napi);
+ napi_synchronize(&adapter->napi);
#endif
- e1000_irq_disable(adapter);
del_timer_sync(&adapter->tx_fifo_stall_timer);
del_timer_sync(&adapter->watchdog_timer);
next prev parent reply other threads:[~2007-11-28 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 18:52 net_rx_action/NAPI oops [PATCH] Robert Olsson
2007-11-27 22:09 ` Stephen Hemminger
2007-11-27 22:34 ` Kok, Auke
2007-11-27 22:55 ` Stephen Hemminger
2007-11-28 0:24 ` Kok, Auke
2007-11-28 12:36 ` Robert Olsson
2007-11-28 16:38 ` Stephen Hemminger [this message]
2007-11-28 17:22 ` Robert Olsson
2007-11-30 16:56 ` Robert Olsson
2007-11-30 17:13 ` Kok, Auke
2007-11-28 12:27 ` Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128083826.3a9400d1@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=Robert.Olsson@data.slu.se \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox