Re: [PATCH] igb/e1000e/e1000/e100: make wol usable

[David Miller <davem@davemloft.net>]

From: Alexander Duyck <alexander.duyck@gmail.com>
Date: Tue, 21 Jul 2009 20:25:31 -0700

> My understanding was that the can_wakeup was supposed to be
> initialized by pci_pm_init or platform_pci_wakeup_init based on the
> pci-e capabilities.  Is this not the case?  It seems like this is
> where you should be looking to determine why the the can_wakeup isn't
> being initialized correctly.
> 
> The patch below won't solve the problem either.  The problem is that
> the can_wakeup value is being disabled when the EEPROM doesn't support
> WOL.
> 
> If you have to do this in the drivers, then my suggestion is to take a
> look at how ixgbe is doing it.  You essentially need to initialize
> can_wakeup to true, and then set the should_wakeup attribute based on
> the EEPROM setting or via ethtool.  This way you can still toggle the
> should_wakeup option without being blocked by the EEPROM disabling it.

It looks like the approach needs to be worked out still, so
I'm tossing these patches from patchwork.

Let me know when a more final fix is ready.

Thanks.