From: David Miller <davem@davemloft.net>
To: peter.p.waskiewicz.jr@intel.com
Cc: andy@greyhouse.net, alexander.duyck@gmail.com,
john.ronciak@intel.com, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, stable@kernel.org
Subject: Re: [PATCH] igb/e1000e/e1000/e100: make wol usable
Date: Thu, 23 Jul 2009 11:06:47 -0700 (PDT) [thread overview]
Message-ID: <20090723.110647.228266156.davem@davemloft.net> (raw)
In-Reply-To: <Pine.WNT.4.64.0907221642110.9900@ppwaskie-MOBL2.amr.corp.intel.com>
From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Wed, 22 Jul 2009 16:43:03 -0700 (Pacific Daylight Time)
> On Wed, 22 Jul 2009, Andy Gospodarek wrote:
>
>> [PATCH] ixgbe: remove unnecessary call to device_init_wakeup
>>
>> Calls to device_init_wakeup should not be necessary in drivers that use
>> device_set_wakeup_enable since pci_pm_init will set the can_wakeup flag
>> for the device when initialized.
>>
>> I can't test this since I don't have any of the 82599 KX4 interfaces
>> (the only ones capable of WOL), but I did instrument ixgbe_probe and
>> know that can_wakeup=1 when device_init_wakeup is removed.
>>
>> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
...
> Works just fine on two different 82599 mezz cards that support WoL.
> Thanks Andy for finding and fixing.
>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Applied, thanks.
prev parent reply other threads:[~2009-07-23 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 21:01 [PATCH] igb/e1000e/e1000/e100: make wol usable Andy Gospodarek
2009-07-21 21:59 ` Ronciak, John
2009-07-22 2:27 ` Andy Gospodarek
2009-07-22 3:25 ` Alexander Duyck
2009-07-22 3:56 ` David Miller
2009-07-22 19:34 ` Andy Gospodarek
2009-07-22 20:00 ` Waskiewicz Jr, Peter P
2009-07-22 23:43 ` Waskiewicz Jr, Peter P
2009-07-23 18:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723.110647.228266156.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.duyck@gmail.com \
--cc=andy@greyhouse.net \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox