From: Andy Gospodarek <andy@greyhouse.net>
To: netdev@vger.kernel.org
Cc: jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, peter.p.waskiewicz.jr@intel.com,
john.ronciak@intel.com, stable@kernel.org
Subject: [PATCH] igb/e1000e/e1000/e100: make wol usable
Date: Tue, 21 Jul 2009 17:01:15 -0400 [thread overview]
Message-ID: <20090721210115.GL8515@gospo.rdu.redhat.com> (raw)
It seems that the patches that intended to use the new calls to check
status and capabilities for WOL and fix it up:
commit bc79fc8409b3dccbde072e8113cc1fb3fd876fc5
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date: Wed Oct 29 14:22:18 2008 -0700
e100: adapt to the reworked PCI PM
commit e1b86d8479f90aadee57a3d07d8e61c815c202d9
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date: Fri Nov 7 20:30:37 2008 +0000
igb: Use device_set_wakeup_enable
commit de1264896c8012a261c1cba17e6a61199c276ad3
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date: Fri Nov 7 20:30:19 2008 +0000
e1000: Use device_set_wakeup_enable
commit 6ff68026f4757d68461b7fbeca5c944e1f5f8b44
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date: Wed Nov 12 09:52:32 2008 +0000
e1000e: Use device_set_wakeup_enable
Unfortunately they left out some important bits. This should make sure
the e100, igb, e1000e, and e1000-based devices can actually enable WOL
rather than their current state which is reported as not supported.
This looks like it has been broken since 2.6.28.
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
---
e100.c | 1 +
e1000/e1000_main.c | 1 +
e1000e/netdev.c | 1 +
igb/igb_main.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 569df19..8824952 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -2816,6 +2816,7 @@ static int __devinit e100_probe(struct pci_dev *pdev,
if ((nic->mac >= mac_82558_D101_A4) &&
(nic->eeprom[eeprom_id] & eeprom_id_wol)) {
nic->flags |= wol_magic;
+ device_init_wakeup(&pdev->dev, true);
device_set_wakeup_enable(&pdev->dev, true);
}
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index d7df00c..229d874 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -1208,6 +1208,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
/* initialize the wol settings based on the eeprom settings */
adapter->wol = adapter->eeprom_wol;
+ device_init_wakeup(&adapter->pdev->dev, adapter->wol);
device_set_wakeup_enable(&adapter->pdev->dev, adapter->wol);
/* print bus type/speed/width info */
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 63415bb..5c2edaa 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -5196,6 +5196,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
/* initialize the wol settings based on the eeprom settings */
adapter->wol = adapter->eeprom_wol;
+ device_init_wakeup(&adapter->pdev->dev, adapter->wol);
device_set_wakeup_enable(&adapter->pdev->dev, adapter->wol);
/* save off EEPROM version number */
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index adb09d3..8512a40 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -1475,6 +1475,7 @@ static int __devinit igb_probe(struct pci_dev *pdev,
/* initialize the wol settings based on the eeprom settings */
adapter->wol = adapter->eeprom_wol;
+ device_init_wakeup(&adapter->pdev->dev, adapter->wol);
device_set_wakeup_enable(&adapter->pdev->dev, adapter->wol);
/* reset the hardware with the new settings */
next reply other threads:[~2009-07-21 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 21:01 Andy Gospodarek [this message]
2009-07-21 21:59 ` [PATCH] igb/e1000e/e1000/e100: make wol usable Ronciak, John
2009-07-22 2:27 ` Andy Gospodarek
2009-07-22 3:25 ` Alexander Duyck
2009-07-22 3:56 ` David Miller
2009-07-22 19:34 ` Andy Gospodarek
2009-07-22 20:00 ` Waskiewicz Jr, Peter P
2009-07-22 23:43 ` Waskiewicz Jr, Peter P
2009-07-23 18:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721210115.GL8515@gospo.rdu.redhat.com \
--to=andy@greyhouse.net \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox